From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DC524DCE6 for ; Mon, 14 Jul 2025 13:39:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752500346; cv=none; b=AfmHv5VHF7uQlFWDlwARsWKJi12w5Wv6WAFw6CsCjI9ItynR21I/lS/29X/N2T/eEfijdbVSSOYD3YupoJXMhtSmSgBIb6ojrBMkbxfAwnaA9FyZDvZjAriM54GJVKkRzzvVozRghF9l0MwZ4zmVGI8b/Rcl54l8EMEla64Bosc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752500346; c=relaxed/simple; bh=uqVM8DCOecLRMSWwfCMP4U2syF28xrRLCFZtT0XQEeA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f8MLrCvnMrm917AEN/iHUToveq4dt/e0FDhq6cETu+uC2VSFecCEXrAUO4Cx4zJ+Xk40fKBFl2OyZQEo5IiaoiibMFIdf4cfIWVL7uKbYUzqZbMvPBb3UhSv9usc30FqJLmtlo6eyQK8G/sNRAiCXnOOhmfJZ4P7ETdPufH6GJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QfmrUGV2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QfmrUGV2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752500343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=78ELezR9/WM68ny3VH62OCs9mnwuCAXrTRQ3vgvPl24=; b=QfmrUGV26aEEIZ+cLl5FOhXIUpzfrUO4DFex4kjVkgcStYFZg0NfvjEHaCK/VasCVuzF06 oEagOkAzv0PMMUjqkXM65fa9E8uFooyOeJL6Jut4sG4AY+ebczeRiNJoALi8kqQdajUyO4 THZ8wemAbJu6X0a0rTwlNYT+sym94LM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-eTBeY3LjNmy-M3LcqYZQdw-1; Mon, 14 Jul 2025 09:39:00 -0400 X-MC-Unique: eTBeY3LjNmy-M3LcqYZQdw-1 X-Mimecast-MFC-AGG-ID: eTBeY3LjNmy-M3LcqYZQdw_1752500337 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C03471955F41; Mon, 14 Jul 2025 13:38:57 +0000 (UTC) Received: from bfoster (unknown [10.22.64.43]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CD3A180045B; Mon, 14 Jul 2025 13:38:56 +0000 (UTC) Date: Mon, 14 Jul 2025 09:42:38 -0400 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, willy@infradead.org Subject: Re: [PATCH v2 7/7] xfs: error tag to force zeroing on debug kernels Message-ID: References: <20250714132059.288129-1-bfoster@redhat.com> <20250714132059.288129-8-bfoster@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Mon, Jul 14, 2025 at 06:23:01AM -0700, Christoph Hellwig wrote: > On Mon, Jul 14, 2025 at 09:20:59AM -0400, Brian Foster wrote: > > - error = xfs_free_file_space(XFS_I(inode), offset, len, ac); > > - if (error) > > - return error; > > + /* randomly force zeroing to exercise zero range */ > > This comment feels very sparse for this somewhat confusing behavior. > Can you add a shortened version of the commit message here explaining > why this is useful? > Sure, will fix. Brian > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >