From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, hch@infradead.org, willy@infradead.org
Subject: Re: [PATCH v3 5/7] xfs: fill dirty folios on zero range of unwritten mappings
Date: Tue, 15 Jul 2025 08:35:51 -0400 [thread overview]
Message-ID: <aHZLJyPmZPmDtLE_@bfoster> (raw)
In-Reply-To: <20250715052811.GQ2672049@frogsfrogsfrogs>
On Mon, Jul 14, 2025 at 10:28:11PM -0700, Darrick J. Wong wrote:
> On Mon, Jul 14, 2025 at 04:41:20PM -0400, Brian Foster wrote:
> > Use the iomap folio batch mechanism to select folios to zero on zero
> > range of unwritten mappings. Trim the resulting mapping if the batch
> > is filled (unlikely for current use cases) to distinguish between a
> > range to skip and one that requires another iteration due to a full
> > batch.
> >
> > Signed-off-by: Brian Foster <bfoster@redhat.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > ---
> > fs/xfs/xfs_iomap.c | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> > index b5cf5bc6308d..63054f7ead0e 100644
> > --- a/fs/xfs/xfs_iomap.c
> > +++ b/fs/xfs/xfs_iomap.c
> > @@ -1691,6 +1691,8 @@ xfs_buffered_write_iomap_begin(
> > struct iomap *iomap,
> > struct iomap *srcmap)
> > {
> > + struct iomap_iter *iter = container_of(iomap, struct iomap_iter,
> > + iomap);
> > struct xfs_inode *ip = XFS_I(inode);
> > struct xfs_mount *mp = ip->i_mount;
> > xfs_fileoff_t offset_fsb = XFS_B_TO_FSBT(mp, offset);
> > @@ -1762,6 +1764,7 @@ xfs_buffered_write_iomap_begin(
> > */
> > if (flags & IOMAP_ZERO) {
> > xfs_fileoff_t eof_fsb = XFS_B_TO_FSB(mp, XFS_ISIZE(ip));
> > + u64 end;
> >
> > if (isnullstartblock(imap.br_startblock) &&
> > offset_fsb >= eof_fsb)
> > @@ -1769,6 +1772,26 @@ xfs_buffered_write_iomap_begin(
> > if (offset_fsb < eof_fsb && end_fsb > eof_fsb)
> > end_fsb = eof_fsb;
> >
> > + /*
> > + * Look up dirty folios for unwritten mappings within EOF.
> > + * Providing this bypasses the flush iomap uses to trigger
> > + * extent conversion when unwritten mappings have dirty
> > + * pagecache in need of zeroing.
> > + *
> > + * Trim the mapping to the end pos of the lookup, which in turn
> > + * was trimmed to the end of the batch if it became full before
> > + * the end of the mapping.
> > + */
> > + if (imap.br_state == XFS_EXT_UNWRITTEN &&
> > + offset_fsb < eof_fsb) {
> > + loff_t len = min(count,
> > + XFS_FSB_TO_B(mp, imap.br_blockcount));
> > +
> > + end = iomap_fill_dirty_folios(iter, offset, len);
> > + end_fsb = min_t(xfs_fileoff_t, end_fsb,
> > + XFS_B_TO_FSB(mp, end));
>
> Hrmm. XFS_B_TO_FSB and not _FSBT? Can the rounding up behavior result
> in a missed byte range? I think the answer is no because @end should be
> aligned to a folio boundary, and folios can't be smaller than an
> fsblock.
>
Hmm.. not that I'm aware of..? Please elaborate if there's a case you're
suspicious of because I could have certainly got my wires crossed.
My thinking is that end_fsb reflects the first fsb beyond the target
range. I.e., it's calculated and used as such in xfs_iomap_end_fsb() and
the various xfs_trim_extent() calls throughout the rest of the function.
Brian
> If the answer to the second question is indeed "no" then I think this is
> ok and
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>
> --D
>
>
> > + }
> > +
> > xfs_trim_extent(&imap, offset_fsb, end_fsb - offset_fsb);
> > }
> >
> > --
> > 2.50.0
> >
> >
>
next prev parent reply other threads:[~2025-07-15 12:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 20:41 [PATCH v3 0/7] iomap: zero range folio batch support Brian Foster
2025-07-14 20:41 ` [PATCH v3 1/7] filemap: add helper to look up dirty folios in a range Brian Foster
2025-07-15 5:20 ` Darrick J. Wong
2025-07-14 20:41 ` [PATCH v3 2/7] iomap: remove pos+len BUG_ON() to after folio lookup Brian Foster
2025-07-15 5:14 ` Darrick J. Wong
2025-07-14 20:41 ` [PATCH v3 3/7] iomap: optional zero range dirty folio processing Brian Foster
2025-07-15 5:22 ` Darrick J. Wong
2025-07-15 12:35 ` Brian Foster
2025-07-18 11:30 ` Zhang Yi
2025-07-18 13:48 ` Brian Foster
2025-07-19 11:07 ` Zhang Yi
2025-07-21 8:47 ` Zhang Yi
2025-07-28 12:57 ` Zhang Yi
2025-07-30 13:19 ` Brian Foster
2025-08-02 7:26 ` Zhang Yi
2025-07-30 13:17 ` Brian Foster
2025-08-02 7:19 ` Zhang Yi
2025-08-05 13:08 ` Brian Foster
2025-08-06 3:10 ` Zhang Yi
2025-08-06 13:25 ` Brian Foster
2025-08-07 4:58 ` Zhang Yi
2025-07-14 20:41 ` [PATCH v3 4/7] xfs: always trim mapping to requested range for zero range Brian Foster
2025-07-14 20:41 ` [PATCH v3 5/7] xfs: fill dirty folios on zero range of unwritten mappings Brian Foster
2025-07-15 5:28 ` Darrick J. Wong
2025-07-15 12:35 ` Brian Foster [this message]
2025-07-15 14:19 ` Darrick J. Wong
2025-07-14 20:41 ` [PATCH v3 6/7] iomap: remove old partial eof zeroing optimization Brian Foster
2025-07-15 5:34 ` Darrick J. Wong
2025-07-15 12:36 ` Brian Foster
2025-07-15 14:37 ` Darrick J. Wong
2025-07-15 16:20 ` Brian Foster
2025-07-15 16:30 ` Darrick J. Wong
2025-07-14 20:41 ` [PATCH v3 7/7] xfs: error tag to force zeroing on debug kernels Brian Foster
2025-07-15 5:24 ` Darrick J. Wong
2025-07-15 12:39 ` Brian Foster
2025-07-15 14:30 ` Darrick J. Wong
2025-07-15 16:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHZLJyPmZPmDtLE_@bfoster \
--to=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).