From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E648415B54A for ; Wed, 16 Jul 2025 08:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752654051; cv=none; b=BfzQQJHHjbCyYlsOLanEIekz+shWhCJGwWXPju7oP6Q1HTybXZnsNPyoB2zascnfRjydrNl4sjSTyWVDMSdCPOa6ihJMOg/W3VH5r1TKLuo6keu70Nc9IF6H846agBP/bgP+bF6XVKfZGFrjD6n1vowaqVytSZvcrSfUc/llm4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752654051; c=relaxed/simple; bh=2zhu4E5WvqW3arFsj3d/kom8REjveF6QEqV1Z4f8OAc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sz7D0AtvrD5hLG7vz36rApMdjDvA3wdUjXbIKX91rB6pxR04+Yj0v6bd1xBUWv9o5C87nR9c4SaXd87SV6ouE9B04WsL66bghm8JbmmvGPPQ5hMEZDVUf9kikK/Btw/TnrU/b2u4PeiC4SvB1oOxtMSNRAg/pMde8Ha3XkxBnUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Kra/SNnC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=k/6sTKZd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Kra/SNnC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=k/6sTKZd; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Kra/SNnC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="k/6sTKZd"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Kra/SNnC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="k/6sTKZd" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D381321235; Wed, 16 Jul 2025 08:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=Kra/SNnCnlFmArihgtpkJnlBzxIFiix4eMZf8WbVVkUNgMLSzRRITKBrwHMb+8Ue4kkSbB 6PvwD7ORnT9v0Rmx+Wr3QL4PXlhl3U9RJ/JDrXNXqtGIqOF3x47fvHiOWLZ3Sx72WtF/d6 pM64q1fFj3EuMQZlsG/KvMhVtNdQQks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=k/6sTKZdoXEEDiueorLGp+Ptu/WsaOoSciT+ZR/RD/N7j9lULKWQVfeKfHwwdOHcPUBzS1 88PpQ07hwEjfNxDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=Kra/SNnCnlFmArihgtpkJnlBzxIFiix4eMZf8WbVVkUNgMLSzRRITKBrwHMb+8Ue4kkSbB 6PvwD7ORnT9v0Rmx+Wr3QL4PXlhl3U9RJ/JDrXNXqtGIqOF3x47fvHiOWLZ3Sx72WtF/d6 pM64q1fFj3EuMQZlsG/KvMhVtNdQQks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752654046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R+hCBYnvSZ+PSORPTHDk4t1hNJZ7tafG6Xa+YTLyPY=; b=k/6sTKZdoXEEDiueorLGp+Ptu/WsaOoSciT+ZR/RD/N7j9lULKWQVfeKfHwwdOHcPUBzS1 88PpQ07hwEjfNxDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5085E138D2; Wed, 16 Jul 2025 08:20:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8H0GEd1gd2jdEQAAD6G6ig (envelope-from ); Wed, 16 Jul 2025 08:20:45 +0000 Date: Wed, 16 Jul 2025 10:20:43 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Lance Yang Subject: Re: [PATCH v1 8/9] mm: introduce and use vm_normal_page_pud() Message-ID: References: <20250715132350.2448901-1-david@redhat.com> <20250715132350.2448901-9-david@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715132350.2448901-9-david@redhat.com> X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[31]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLhwqoz3wsm4df3nfubx4grhps)]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,localhost.localdomain:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -4.30 On Tue, Jul 15, 2025 at 03:23:49PM +0200, David Hildenbrand wrote: > Let's introduce vm_normal_page_pud(), which ends up being fairly simple > because of our new common helpers and there not being a PUD-sized zero > folio. > > Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO, > structuring the code like the other (pmd/pte) cases. Defer > introducing vm_normal_folio_pud() until really used. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs