From: Matthew Wilcox <willy@infradead.org>
To: alexjlzheng@gmail.com
Cc: brauner@kernel.org, djwong@kernel.org,
dave.hansen@linux.intel.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jinliang Zheng <alexjlzheng@tencent.com>
Subject: Re: [PATCH] iomap: move prefaulting out of hot write path
Date: Sun, 27 Jul 2025 23:10:51 +0100 [thread overview]
Message-ID: <aIaj69N19WCbKKy8@casper.infradead.org> (raw)
In-Reply-To: <20250726090955.647131-2-alexjlzheng@tencent.com>
On Sat, Jul 26, 2025 at 05:09:56PM +0800, alexjlzheng@gmail.com wrote:
> @@ -992,6 +977,12 @@ static int iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i)
> if (mapping_writably_mapped(mapping))
> flush_dcache_folio(folio);
>
> + /*
> + * copy_folio_from_iter_atomic() short-circuits page fault handle
> + * logics via pagefault_disable(), to prevent deadlock scenarios
> + * when both source and destination buffers reside within the same
> + * folio (mmap, ...).
> + */
Why did you change this comment from the one in 665575cff098?
The comment in that commit is correct. This comment is so badly
mangled, it isn't even wrong.
prev parent reply other threads:[~2025-07-27 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-26 9:09 [PATCH] iomap: move prefaulting out of hot write path alexjlzheng
2025-07-27 22:10 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIaj69N19WCbKKy8@casper.infradead.org \
--to=willy@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=brauner@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).