From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, snitzer@kernel.org,
axboe@kernel.dk, dw@davidwei.uk, brauner@kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCHv2 0/7] direct-io: even more flexible io vectors
Date: Mon, 11 Aug 2025 03:32:52 -0700 [thread overview]
Message-ID: <aJnG1H4XXL8AXHcS@infradead.org> (raw)
In-Reply-To: <aJU0scj_dR8_37S8@kbusch-mbp>
On Thu, Aug 07, 2025 at 05:20:17PM -0600, Keith Busch wrote:
> Sure. I wrote up some for blktest, and the same test works as-is for
> filesystems too. Potential question: where do such programs go
> (xfstests, blktests, both, or some common place)?
We currently have no good way to share tests between xfstest and
blktests, so I think it would require duplicating the helper programs.
> I tested on loop, nvme, and virtio-blk, both raw block (blktests) and
> xfs (fstests). Seems fine.
Cool. I'd like the hear from the other XFS folks if the possibility
of easily introducing preallocated space (that's what it looks like on
disk) for writes failed because of wrong alignment is fine. Given that
the same user could introduce them using fallocate it's definitively not
a security issue, but also rather unusual and unexpected. And from the
other file system maintainers if they have similar issues.
prev parent reply other threads:[~2025-08-11 10:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 14:11 [PATCHv2 0/7] direct-io: even more flexible io vectors Keith Busch
2025-08-05 14:11 ` [PATCHv2 1/7] block: check for valid bio while splitting Keith Busch
2025-08-10 14:37 ` Christoph Hellwig
2025-08-10 15:39 ` Keith Busch
2025-08-10 17:14 ` Christoph Hellwig
2025-08-13 20:06 ` Keith Busch
2025-08-13 20:41 ` Bart Van Assche
2025-08-13 21:01 ` Keith Busch
2025-08-13 23:17 ` Bart Van Assche
2025-08-14 1:42 ` Damien Le Moal
2025-08-13 21:23 ` Martin K. Petersen
2025-08-13 21:52 ` Keith Busch
2025-08-18 4:49 ` Christoph Hellwig
2025-08-05 14:11 ` [PATCHv2 2/7] block: align the bio after building it Keith Busch
2025-08-06 6:07 ` Hannes Reinecke
2025-08-10 14:43 ` Christoph Hellwig
2025-08-05 14:11 ` [PATCHv2 3/7] block: simplify direct io validity check Keith Busch
2025-08-05 14:11 ` [PATCHv2 4/7] iomap: " Keith Busch
2025-08-06 6:07 ` Hannes Reinecke
2025-08-05 14:11 ` [PATCHv2 5/7] block: remove bdev_iter_is_aligned Keith Busch
2025-08-05 14:11 ` [PATCHv2 6/7] blk-integrity: use simpler alignment check Keith Busch
2025-08-05 14:11 ` [PATCHv2 7/7] iov_iter: remove iov_iter_is_aligned Keith Busch
2025-08-06 6:08 ` Hannes Reinecke
2025-08-06 3:03 ` [PATCHv2 0/7] direct-io: even more flexible io vectors Martin K. Petersen
2025-08-06 14:51 ` Christoph Hellwig
2025-08-07 23:20 ` Keith Busch
2025-08-11 10:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJnG1H4XXL8AXHcS@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dw@davidwei.uk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).