From: Christoph Hellwig <hch@infradead.org>
To: Nanzhe Zhao <nzzhao@126.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>, Chao Yu <chao@kernel.org>,
Yi Zhang <yi.zhang@huawei.com>, Barry Song <21cnbao@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [f2fs-dev] [RFC PATCH 0/9] f2fs: Enable buffered read/write large folios support with extended iomap
Date: Wed, 13 Aug 2025 08:22:37 -0700 [thread overview]
Message-ID: <aJytvfsMcR2hzWKI@infradead.org> (raw)
In-Reply-To: <20250813092131.44762-1-nzzhao@126.com>
On Wed, Aug 13, 2025 at 05:21:22PM +0800, Nanzhe Zhao wrote:
> * **Why extends iomap**
> * F2FS stores its flags in the folio's private field,
> which conflicts with iomap_folio_state.
> * To resolve this, we designed f2fs_iomap_folio_state,
> compatible with iomap_folio_state's layout while extending
> its flexible state array for F2FS private flags.
> * We store a magic number in read_bytes_pending to distinguish
> whether a folio uses the original or F2FS's iomap_folio_state.
> It's chosen because it remains 0 after readahead completes.
That's pretty ugly. What additionals flags do you need? We should
try to figure out if there is a sensible way to support the needs
with a single codebase and data structure if that the requirements
are sensible.
next prev parent reply other threads:[~2025-08-13 15:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 9:21 [f2fs-dev] [RFC PATCH 0/9] f2fs: Enable buffered read/write large folios support with extended iomap Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 1/9] f2fs: Introduce f2fs_iomap_folio_state Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 2/9] f2fs: Integrate f2fs_iomap_folio_state into f2fs page private helpers Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 3/9] f2fs: Using `folio_detach_f2fs_private` in invalidate and release folio Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 4/9] f2fs: Convert outplace write path page private funcions to folio private functions Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 5/9] f2fs:Refactor `f2fs_is_compressed_page` to `f2fs_is_compressed_folio` Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 6/9] f2fs: Extend f2fs_io_info to support sub-folio ranges Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 7/9] f2fs:Make GC aware of large folios Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 8/9] f2fs: Introduce F2FS_GET_BLOCK_IOMAP and map_blocks he lpers Nanzhe Zhao
2025-08-13 9:21 ` [RFC PATCH 9/9] f2fs: Enable buffered read/write path large folios support for normal and atomic file with iomap Nanzhe Zhao
2025-08-13 15:22 ` Christoph Hellwig [this message]
2025-08-14 0:39 ` Re:Re: [f2fs-dev] [RFC PATCH 0/9] f2fs: Enable buffered read/write large folios support with extended iomap 赵南哲
2025-08-17 4:43 ` Nanzhe Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJytvfsMcR2hzWKI@infradead.org \
--to=hch@infradead.org \
--cc=21cnbao@gmail.com \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nzzhao@126.com \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).