From: Matthew Wilcox <willy@infradead.org>
To: Trond Myklebust <trondmy@kernel.org>
Cc: Anna Schumaker <anna@kernel.org>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH v3 1/2] filemap: Add a helper for filesystems implementing dropbehind
Date: Mon, 18 Aug 2025 17:08:52 +0100 [thread overview]
Message-ID: <aKNQFBhhTIkUbK6e@casper.infradead.org> (raw)
In-Reply-To: <5109a45f43249d88882400f92e0cef27503c0704.camel@kernel.org>
On Mon, Aug 18, 2025 at 08:59:41AM -0700, Trond Myklebust wrote:
> On Mon, 2025-08-18 at 15:51 +0100, Matthew Wilcox wrote:
> > On Mon, Aug 18, 2025 at 07:39:49AM -0700, Trond Myklebust wrote:
> > > +void folio_end_dropbehind(struct folio *folio)
> > > +{
> > > + filemap_end_dropbehind_write(folio);
> > > +}
> > > +EXPORT_SYMBOL(folio_end_dropbehind);
> >
> > Why not just export filemap_end_dropbehind_write()?
>
> It seemed more appropriate to use the 'folio' prefix when exporting, so
> that it is symmetric with folio_end_writeback().
>
> I'm perfectly fine with changing that if people disagree.
I don't mind renaming filemap_end_dropbehind_write() to
folio_end_dropbehind() as a solution!
next prev parent reply other threads:[~2025-08-18 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 14:39 [PATCH v3 0/2] Initial NFS client support for RWF_DONTCACHE Trond Myklebust
2025-08-18 14:39 ` [PATCH v3 1/2] filemap: Add a helper for filesystems implementing dropbehind Trond Myklebust
2025-08-18 14:51 ` Matthew Wilcox
2025-08-18 15:59 ` Trond Myklebust
2025-08-18 16:08 ` Matthew Wilcox [this message]
2025-08-18 14:39 ` [PATCH v3 2/2] NFS: Enable the RWF_DONTCACHE flag for the NFS client Trond Myklebust
2025-08-18 15:21 ` Matthew Wilcox
2025-08-18 15:56 ` Trond Myklebust
2025-08-18 15:58 ` Matthew Wilcox
2025-08-18 16:49 ` Trond Myklebust
2025-08-18 17:04 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKNQFBhhTIkUbK6e@casper.infradead.org \
--to=willy@infradead.org \
--cc=anna@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).