From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, snitzer@kernel.org,
axboe@kernel.dk, dw@davidwei.uk, brauner@kernel.org,
martin.petersen@oracle.com, djwong@kernel.org,
linux-xfs@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCHv3 3/8] block: align the bio after building it
Date: Mon, 25 Aug 2025 07:57:49 -0600 [thread overview]
Message-ID: <aKxr3a74EjiyEUUA@kbusch-mbp> (raw)
In-Reply-To: <20250825074606.GE20853@lst.de>
On Mon, Aug 25, 2025 at 09:46:06AM +0200, Christoph Hellwig wrote:
> On Tue, Aug 19, 2025 at 09:49:17AM -0700, Keith Busch wrote:
> > +
> > + if (!bio->bi_iter.bi_size)
> > + return -EFAULT;
>
> And as bi_size doesn't change in the loop, this should probably move
> above the loop.
The loop also releases pinned pages if necessary. We can't count on the
caller to do that if we return error here. __blkdev_direct_IO is the
only one that tries to release pages on error, everyone else would leak
them.
next prev parent reply other threads:[~2025-08-25 13:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 16:49 [PATCHv3 0/8] direct-io: even more flexible io vectors Keith Busch
2025-08-19 16:49 ` [PATCHv3 1/8] block: check for valid bio while splitting Keith Busch
2025-08-20 7:02 ` Damien Le Moal
2025-08-20 14:25 ` Keith Busch
2025-08-20 7:04 ` Damien Le Moal
2025-08-25 7:35 ` Christoph Hellwig
2025-08-19 16:49 ` [PATCHv3 2/8] block: add size alignment to bio_iov_iter_get_pages Keith Busch
2025-08-25 7:36 ` Christoph Hellwig
2025-08-19 16:49 ` [PATCHv3 3/8] block: align the bio after building it Keith Busch
2025-08-20 7:07 ` Damien Le Moal
2025-08-25 7:46 ` Christoph Hellwig
2025-08-25 13:57 ` Keith Busch [this message]
2025-08-25 7:47 ` Christoph Hellwig
2025-08-26 0:37 ` Keith Busch
2025-08-26 8:02 ` Christoph Hellwig
2025-08-26 23:11 ` Keith Busch
2025-08-19 23:36 ` [PATCHv3 0/8] direct-io: even more flexible io vectors Mike Snitzer
2025-08-20 1:52 ` Song Chen
2025-08-22 13:27 ` Ritesh Harjani
2025-08-22 14:30 ` Keith Busch
2025-08-25 12:07 ` Jan Kara
2025-08-25 14:53 ` Keith Busch
2025-08-26 4:59 ` Ritesh Harjani
2025-08-27 15:20 ` Jan Kara
2025-08-27 16:09 ` Mike Snitzer
2025-09-01 7:55 ` Jan Kara
2025-09-02 14:39 ` Mike Snitzer
2025-08-27 17:52 ` Brian Foster
2025-08-27 19:20 ` Keith Busch
2025-09-01 8:22 ` Jan Kara
2025-08-29 2:11 ` Ritesh Harjani
2025-08-29 3:19 ` Ritesh Harjani
[not found] ` <20250819164922.640964-5-kbusch@meta.com>
2025-08-25 7:48 ` [PATCHv3 4/8] block: simplify direct io validity check Christoph Hellwig
[not found] ` <20250819164922.640964-6-kbusch@meta.com>
2025-08-25 7:48 ` [PATCHv3 5/8] iomap: " Christoph Hellwig
[not found] ` <20250819164922.640964-7-kbusch@meta.com>
2025-08-25 7:48 ` [PATCHv3 6/8] block: remove bdev_iter_is_aligned Christoph Hellwig
[not found] ` <20250819164922.640964-8-kbusch@meta.com>
2025-08-25 7:49 ` [PATCHv3 7/8] blk-integrity: use simpler alignment check Christoph Hellwig
[not found] ` <20250819164922.640964-9-kbusch@meta.com>
2025-08-25 7:50 ` [PATCHv3 8/8] iov_iter: remove iov_iter_is_aligned Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKxr3a74EjiyEUUA@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=dw@davidwei.uk \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).