From: Christoph Hellwig <hch@infradead.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: brauner@kernel.org, bfoster@redhat.com, hch@infradead.org,
djwong@kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] iomap: simplify iomap_iter_advance()
Date: Mon, 22 Sep 2025 11:23:55 -0700 [thread overview]
Message-ID: <aNGUO8lNnFkDEt5Y@infradead.org> (raw)
In-Reply-To: <20250919214250.4144807-1-joannelkoong@gmail.com>
On Fri, Sep 19, 2025 at 02:42:50PM -0700, Joanne Koong wrote:
> Most callers of iomap_iter_advance() do not need the remaining length
> returned. Get rid of the extra iomap_length() call that
> iomap_iter_advance() does.
> 6 files changed, 35 insertions(+), 47 deletions(-)
This ended up beeing a pretty nice sinmplification, nice!
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-09-22 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 21:42 [PATCH v2] iomap: simplify iomap_iter_advance() Joanne Koong
2025-09-19 21:49 ` Joanne Koong
2025-09-22 18:23 ` Christoph Hellwig [this message]
2025-09-29 8:32 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNGUO8lNnFkDEt5Y@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).