From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71A1928B7D7 for ; Wed, 24 Sep 2025 09:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758706505; cv=none; b=YXq1pKRUMeHxNTyzbKS6Q5ajKPwQDQontZ9ag+rgz+nS2Z5GYoyOkaRYkzE+LGrfLPYCXYKWzAVQ/q6OuO2CiJH0ut6VRdPmiNuWuHu0TF8wjRa/3vMFadG4cfTXOEfo7eOYHnLh/obMSKAFGvTs22UT2OhUxJRdYMAKQSKPFo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758706505; c=relaxed/simple; bh=EdSj7XyjXNLxblWCPzkm4+X0r8bfo8yjVByZdAGJVks=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NDlk6T94eM6zok8EbRrEtGsukf5fr6xyH417DshQWcBvaDGT92a7aZgb4rYXGWXWHKWv+7fCd9dqvrhG8Sele3xtUGNk67RFeFOpuF288mvE1e/VFfq00jRABNYq5OU1m8CgzD+vGa1wc5aLjYSkOZYbYD/zR01Hg1YIUOBTcqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=kI57BJlw; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kI57BJlw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZAi7lXvEgORvZhBvHXD3X3G+zXby6uKr4YgM6Zs0hmA=; b=kI57BJlwwkJXejCp1ft3l/DMap jBBDotBFHrzd5ZatAbSLz/9L5dnZA/vdgITa/GHUxktW9IYaQcfjIsq+fHEEyyhjrPFMmImqDn/sj t9+qcyD2KK387bagEij72BCsTN+VUtaNO/uWLVefpvY/pLBwR3e64dtHYyVLPE2pXLxSTgoCMp4B6 DciXgx8ZirhKQr4gym//FmFOIYGMcuSsl5SdgHgTjCx60c7A1KGPPVPVy9AlFyc8ys0/IUcu0pnBc 6i1F2G7IJhDSJmM/J9A7FA1IGOjNUv4ZMHQZaoa4vm4ZBLH1hDTYEOkJgGoEiNrSFCl7grLfgZqtC fv8FeXdw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1v1LqP-0000000Cq2O-1vjO; Wed, 24 Sep 2025 09:31:25 +0000 Date: Wed, 24 Sep 2025 10:31:25 +0100 From: Matthew Wilcox To: Kiryl Shutsemau Cc: Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, Dave Chinner Subject: Re: [RFC PATCH 2/2] fs: Defer evicting inodes to a workqueue Message-ID: References: <20250924091000.2987157-1-willy@infradead.org> <20250924091000.2987157-3-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 24, 2025 at 10:28:09AM +0100, Kiryl Shutsemau wrote: > > +static void deferred_dispose_inodes(struct list_head *inodes) > > +{ > > + unsigned long flags; > > + > > + spin_lock_irqsave(&deferred_inode_lock, flags); > > Why _irqsave? I don't see any interactions with interrupts. Can't we enter reclaim from paths which have interrupts disabled? I could easily be wrong about that. > > + list_splice_tail(inodes, &deferred_inode_list); > > + spin_unlock_irqrestore(&deferred_inode_lock, flags); > > + > > + printk("deferring some inodes\n"); > > Debug leftovers? Oops. Thanks.