From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 627C42FA0C6 for ; Tue, 14 Oct 2025 16:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760458668; cv=none; b=OLgWgvQP/zLXNlRf8LJ0DsnfgkPM/bYkqN6E7ihV7R3f61sJ1bSJj7/NWL2mXb9f9SWu2qvdCrkb5C+9klCKo2l2ClMUNdDaWSDqhVy3k9vgeq5Q53LbF69q6wPMto8ZzHpKNDPv3SSZBjBXfyQbOfDWyecrpJC0df2w6KmSgAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760458668; c=relaxed/simple; bh=sXYeV6SJvnYFewQXtnz8bcuu33UPWzv6xA4EwlwAh/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rIbLZSpU2nfT/w4vIT+xcGM7jCTtoR8O5goQTnEtrIpAPHRyCjoHP4Udcamu1srA/+ashWdiMl+cfHyugcHChktpkEada1dKGYytcO0nytj9+3zsZSLqvIt14M9QAT3Z32C5PGmMbGESBm2t5+cAohxlB+2QJSLUipavpsorFrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JXuZJAub; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JXuZJAub" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760458666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o9khWbtiHfpLUnJNco9dO+izGUV0ZZpx22djFvdPesc=; b=JXuZJAub8GdFurfhm9tYlUrEi6MXoKbYiRSbDxzTEmzAkbEgPhhZmVw0UpFPF2Y+EReCUZ CoDEwiQ9TMHFG8rXqUmupmdvDVGaHGzHUNcFWGFRs/9uunMp10gBwh4St/46SIqbSmUaIc lUChNK0VybNuRMhpTdlPlGcDe5Z9FiE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-td5a2psvMYeZyIlTF0Xn0A-1; Tue, 14 Oct 2025 12:17:42 -0400 X-MC-Unique: td5a2psvMYeZyIlTF0Xn0A-1 X-Mimecast-MFC-AGG-ID: td5a2psvMYeZyIlTF0Xn0A_1760458660 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 666CA1800447; Tue, 14 Oct 2025 16:17:40 +0000 (UTC) Received: from bfoster (unknown [10.22.80.119]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 010B21954107; Tue, 14 Oct 2025 16:17:38 +0000 (UTC) Date: Tue, 14 Oct 2025 12:21:48 -0400 From: Brian Foster To: Miklos Szeredi Cc: lu gu , Joanne Koong , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Bernd Schubert Subject: Re: [PATCH 5.15] fuse: Fix race condition in writethrough path A race Message-ID: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Tue, Oct 14, 2025 at 06:10:45PM +0200, Miklos Szeredi wrote: > On Tue, 14 Oct 2025 at 15:57, Brian Foster wrote: > > > But TBH, if the writeback thing or something similarly simple works for > > resolving the immediate bug, I wouldnt worry too much about it > > until/unless there are userspace fs' explicitly looking for that sort of > > behavior. Just my .02. > > Agreed. > > I just feel it unfortunate that this is default in libfuse and so many > filesystems will have auto_inval_data enabled which don't even need > it, and some mixed read-write workloads suffering badly as a > consequence. > Maybe it didnt really need to be on by default? I don't recall caring much about that (but again, long time ago) as long as the fs that wants it can enable it. Brian > Thanks, > Miklos >