From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, brauner@kernel.org,
djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] iomap: add IOMAP_DIO_ALIGNED flag for btrfs
Date: Mon, 13 Oct 2025 00:11:49 -0700 [thread overview]
Message-ID: <aOymNZtfK3NXqGyJ@infradead.org> (raw)
In-Reply-To: <595ea9e3-0f3a-4aa3-8915-de10e3085a8b@gmx.com>
On Mon, Oct 13, 2025 at 05:36:25PM +1030, Qu Wenruo wrote:
> > Please avoid overly long lines in the iomap code.
>
> I'm not sure if this line (83 chars) counts as long lines.
> As the recent patchchecker will only report lines over 100 chars as long.
But checkpatch is as often wrong, longer than 80 is only allowed when
it improves readability. For iomap as for many subsystems that's only
for long printk lines.
prev parent reply other threads:[~2025-10-13 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 6:08 [PATCH] iomap: add IOMAP_DIO_ALIGNED flag for btrfs Qu Wenruo
2025-10-13 6:33 ` Christoph Hellwig
2025-10-13 7:06 ` Qu Wenruo
2025-10-13 7:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOymNZtfK3NXqGyJ@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).