From: Matthew Wilcox <willy@infradead.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: brauner@kernel.org, djwong@kernel.org, hch@infradead.org,
bfoster@redhat.com, linux-fsdevel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH v2 3/8] iomap: optimize pending async writeback accounting
Date: Wed, 22 Oct 2025 15:23:22 +0100 [thread overview]
Message-ID: <aPjo2om1maIKdCEE@casper.infradead.org> (raw)
In-Reply-To: <20251021164353.3854086-4-joannelkoong@gmail.com>
On Tue, Oct 21, 2025 at 09:43:47AM -0700, Joanne Koong wrote:
> static int iomap_writeback_range(struct iomap_writepage_ctx *wpc,
> struct folio *folio, u64 pos, u32 rlen, u64 end_pos,
> - bool *wb_pending)
> + unsigned *bytes_pending)
This makes me nervous. You're essentially saying "we'll never support
a folio larger than 2GiB" and I disagree. I think for it to become a
practical reality to cache files in 4GiB or larger chunks, we'll need
to see about five more doublings in I/O bandwidth. Looking at the
progression of PCIe recently that's only about 15 years out.
I'd recommend using size_t here to match folio_size().
next prev parent reply other threads:[~2025-10-22 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 16:43 [PATCH v2 0/8] iomap: buffered io changes Joanne Koong
2025-10-21 16:43 ` [PATCH v2 1/8] iomap: account for unaligned end offsets when truncating read range Joanne Koong
2025-10-21 16:43 ` [PATCH v2 2/8] docs: document iomap writeback's iomap_finish_folio_write() requirement Joanne Koong
2025-10-21 16:43 ` [PATCH v2 3/8] iomap: optimize pending async writeback accounting Joanne Koong
2025-10-22 4:49 ` Christoph Hellwig
2025-10-22 14:23 ` Matthew Wilcox [this message]
2025-10-22 21:29 ` Joanne Koong
2025-10-21 16:43 ` [PATCH v2 4/8] iomap: simplify ->read_folio_range() error handling for reads Joanne Koong
2025-10-21 16:43 ` [PATCH v2 5/8] iomap: simplify when reads can be skipped for writes Joanne Koong
2025-10-21 16:43 ` [PATCH v2 6/8] iomap: use loff_t for file positions and offsets in writeback code Joanne Koong
2025-10-21 16:43 ` [PATCH v2 7/8] iomap: use find_next_bit() for dirty bitmap scanning Joanne Koong
2025-10-21 16:43 ` [PATCH v2 8/8] iomap: use find_next_bit() for uptodate " Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPjo2om1maIKdCEE@casper.infradead.org \
--to=willy@infradead.org \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=joannelkoong@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).