From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C798F32B997 for ; Fri, 24 Oct 2025 17:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761327156; cv=none; b=BrT0zrpLDiLPGuqhORDoGcdyP7mCJpMI5OruVH5q/bEBE69J1MsO+un79c/gzDAdZWKr/JsMJn68vd/CM015ttf4W3R9TCvGt5xxZ8HX1eyF88z9is9w8Bq5F1N+K3AGc6ZVwtKLlOZivcFaJkS+LcOpBNQA6EGYmp02zMg85rY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761327156; c=relaxed/simple; bh=UpAvej523gjBWiVNLg/BeJTlpEBeruOMQsLrtxPGcjQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lGdW0kjHic9G9UBqkTE687ePDN/KpmSmntb0HvQE89dhk0AYJtuKvq8rxBR8Bq492LcWQsCnr1ZKxPfpxVWr4D6psBMNLBSnyXGykObogdojqj6kCcgD4PstYps3FNe6+pBYgPB6x/xQY/T5zSqH6VkwzcvLudS9+f4VDebRg7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=YIxKOjvZ; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="YIxKOjvZ" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-89ef0cec908so12655385a.1 for ; Fri, 24 Oct 2025 10:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1761327152; x=1761931952; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=68b/g5DOQEfyTkIlrk7BVq23q9O97J8PIirLY9E/558=; b=YIxKOjvZzvpj/k7qXRAnRBWIDBkC/oznFiyvfaOIcKDF07U4AepP8Nw5JcmEvUqde0 EpwUflB25Mqv2Qcmi2nBiaTOMRSWH0j/9ytlAAZvOj8G10xETo30J0fsc/Ufxr4Qq5Lw ss3WOe/xkm9fpVGq7mxny2WXlW0I+zqosNr/aoTeggYRJcNxwWQiUA55f2kLuKroABjY QpHt014/fVwnwiuMxCtbU40diHYDYXIyk3cXX7XI4lABcUbrJmR33t80rayU5kdJS3tW Mcmn6LcPyc0L9Wlsn+bH40VQHBM2oHPU+p11Liq2TsD0eV4DmWnJdI6TDpfN1idM27fP WmAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761327152; x=1761931952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=68b/g5DOQEfyTkIlrk7BVq23q9O97J8PIirLY9E/558=; b=KTVdx4n0NK+VRYrCrY3k0GGhjhnrz+ZUijZRUWl0x1j7245keD5Q4JVWjq+IWpfTb8 R1iVhCA1nkljMzKBPIF6lCLclv273jRABDT7mASc3oi37McrNfZ6e6cY+Lf0U8rwc7Bd 7z9s6PRTErrGmSUWFEgduuSbG8lXARbI/5ktwHwR0ZzgQUTr5vHJG1TlfCzrTYnkIXcE Uny1U2qRTH/DckufVxgDgEJPYtI6GkgZ2hAYxQ1ShcZT+fwhB4wuXuUCfP70OVNrEcAB X3oaoOw3uDYpsZTJ/xcRMqYzOfL5RIQ7+VM1mejkkUFBzLIQYrt1Sw/yfLwfNDXC+GQG LMbw== X-Forwarded-Encrypted: i=1; AJvYcCVb0m/FQ2Vr5twZijKVslu6tl5tHQnItQ/z5I1FCz5JOcl0VuG9DZFWda7xodxuBooJuxX5cAZndyKcHFYM@vger.kernel.org X-Gm-Message-State: AOJu0YxsUzzimM53Tvk5rGHI7GIICSbBwF5vcUMx8FfT24Qh+rtWkcK6 zP+lm+K40ui4+tS9x2Q4yEbDwznZ/GhyR/Odx5Bmmr+98PFShyKAbiWNyy+o08RV41A= X-Gm-Gg: ASbGncuuuXdRELmBlaI/LWMm08gTHqynTxwqVOGwU73dJao2FIyG1ceJZ9OOmPO+mRx 1gqj+B3Eg1a1R3VBL8yjGIomtutg2yWTBTW37JYmquqemMZSF3RHzcwBWq37lKnb3QARPfa1bGI knpqKa9npzySdmudU/er7H9PFL5heR/72RZDjBNGYiryqnS49uEBXd71A1sdv20vC4FQ2VxADH/ 9TkQtLQFgw8n2oZ6WK6AjQ4XabCzmuxhvLlW1+hEkVhOEzrXuDiSJNf4dkUC7HNKPrYKqGR3HBf 5pOerhTlK8YRtIuYNy8/PAy6H7IQWy7IiZipWXl32DXfx0Sq/FdInzMBmdeBGhMlSCQnj8NOgzC fkEu6+y3NHajcYswvS9vEQEJ6xVxaQnXCG4DoZCp5BQC8FFpB5hK82ltKzF67xflgQCqcWo+7ZZ jiam02qARpcBM0IHnUWzGVTQ/hLLX2NMY57vMgitaYauzxBLAAbkkudfmkuf/FgN6mnq46OA== X-Google-Smtp-Source: AGHT+IHmBN0+9+r5KY4AyoghUj0jEXWjqZKGqzuPjvXeVNzt6iAcmzIlgz93IE1ZHjH55zZ3g6T32Q== X-Received: by 2002:a05:620a:2950:b0:88e:aae4:9599 with SMTP id af79cd13be357-89dbfc9f46cmr377281085a.10.1761327152303; Fri, 24 Oct 2025 10:32:32 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89eadc0ab82sm58312485a.53.2025.10.24.10.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 10:32:31 -0700 (PDT) Date: Fri, 24 Oct 2025 13:32:29 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Peter Xu , Matthew Wilcox , Jason Gunthorpe , Leon Romanovsky , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 05/12] fs/proc/task_mmu: refactor pagemap_pmd_range() Message-ID: References: <2ce1da8c64bf2f831938d711b047b2eba0fa9f32.1761288179.git.lorenzo.stoakes@oracle.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ce1da8c64bf2f831938d711b047b2eba0fa9f32.1761288179.git.lorenzo.stoakes@oracle.com> On Fri, Oct 24, 2025 at 08:41:21AM +0100, Lorenzo Stoakes wrote: > Separate out THP logic so we can drop an indentation level and reduce the > amount of noise in this function. > > We add pagemap_pmd_range_thp() for this purpose. > > While we're here, convert the VM_BUG_ON() to a VM_WARN_ON_ONCE() at the > same time. > > Signed-off-by: Lorenzo Stoakes ... >8 > +static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, > + struct mm_walk *walk) > +{ > + struct vm_area_struct *vma = walk->vma; > + struct pagemapread *pm = walk->private; > + spinlock_t *ptl; > + pte_t *pte, *orig_pte; > + int err = 0; > + > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > + ptl = pmd_trans_huge_lock(pmdp, vma); > + if (ptl) > + return pagemap_pmd_range_thp(pmdp, addr, end, vma, pm, ptl); > +#endif Maybe something like... #ifdef CONFIG_TRANSPARENT_HUGEPAGE ptl = pmd_trans_huge_lock(pmdp, vma); if (ptl) { err = pagemap_pmd_range_thp(pmdp, addr, end, vma, pm, ptl); spin_unlock(ptl); return err; } #endif and drop the spin_unlock(ptl) calls from pagemap_pmd_range_thp? Makes it easier to understand the locking semantics. Might be worth adding a comment to pagemap_pmd_range_thp that callers must hold the ptl lock. ~Gregory P.S. This patch set made my day, the whole non-swap-swap thing has always broken my brain. <3