From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D5FF34677C for ; Fri, 24 Oct 2025 17:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761327912; cv=none; b=BeRlEFD7uA6vZwTcL1DSX3Ic4jrrZJfCkoOOtZEF0Y6npyriGq1qvEbl5IRWfoMPqCF2DgzAjBqGKqR60KA0xG0DyJZlrM+QMtKB28MNloxdMFnHr+Ux5ebuh3NoYaH99Rg+PUKJTlO8y/4oc4PZ7h/1SoQu2flD/QmtC5QEp20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761327912; c=relaxed/simple; bh=tQchZRo3dfbeEwC4XDdsg27WfVhtytszSYNfMKLDCRk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UwkLD3YRJKwKI+y1L8jV5S8k5wietFvEb8j/47M8fcYwBcguHwHSDHNVl1h6KjJVWSG1v0v2xxdTmJAKe3IHLyPZqJgqeutHyoqxvNOajLyEdnPkVoMLOizqh5uJPYB4er8C2XmyFNl7E71UTCHRQESIydTgjU5pP2MBJD1Vo9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eMnn1vD1; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eMnn1vD1" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-339b704e2e3so2303767a91.2 for ; Fri, 24 Oct 2025 10:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761327909; x=1761932709; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9y+RsixQBpMVe8jJ0C0RXhB2GIgsnXkIXIfG2sQ8Z6s=; b=eMnn1vD19Z/AtaGDFSF76Wb8pRldCfdAtrfp1z69jekrJASMUIUv9+MIv6TvFAfRu6 meQ0LfQQ/jR3vKxASa8LfEkRwsNQd7cj+hmP0frmqxGXeetPdpXMxuT/Ru/Ahw3k9aQM Zxm5CDHnuhXKwVpLeYm0irNSMLKxvD5bObbmgxRvzQoC1djM24HFU3UAj5LDYGrE1TVL YQVJEer+k6g9sIAGfgKz6uX0vCZYvpHKq84L5IMW+Z3daaahF3rW3wNdwRrgfN4WWUvk VNZ7dQ8vPBa8XDSIllX2KL2P1khde5viPudpfO/vjBiQsP4nJS35nq9fXrpVfHEI/RC+ BC3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761327909; x=1761932709; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9y+RsixQBpMVe8jJ0C0RXhB2GIgsnXkIXIfG2sQ8Z6s=; b=mRu6KIngprl2X8LL+5Qe0OQlCOyKJwpXJBlbJUIjHX2e7MngNd9QslMFYBbDQTduuJ oq/sR58wRDi80/8jAp9oKAoKrgXpjE/ub10Pz7kpb8DROtghrpjVuaEE8j06SXF3V4Hm ekmbaDtwqbSYwgAiO0cjm+hFBt6+xAkU+fTHGHSQe14bLBvo8qILX9/Wh1yNtIuTNuaW RqVc24PBrhCtbDKmTfjKkxXJTP67XMRJ/eRQ+KXfKxpr4+BY2Lm5qSco7wr/kBYEwL5k tV2lNbXnlNN1NgOid1EmrOaL414/QcutxlmAp7M7NewGDDtzhhF3xcrRtMIqB68UHIZg gQzw== X-Forwarded-Encrypted: i=1; AJvYcCWHGwS1AcJnqInjKr/Zrg9JY/4adPjss6ZTGKizk4GRJV8lR17GPX7Dgv7JMlwlE7bmIiVCh06MfAKwdUcZ@vger.kernel.org X-Gm-Message-State: AOJu0YzWXXLznMcjLM+uQSdtp3MhWbDF5dkSLfDJwSi+H5fkJIptQGg1 oHQglXvIN14rlfqzCTUipISQ4CcaF1ZeO7uKmsY7iItJlM5hYV6ya9GDWOb6R8VH7nE9RDzIVCU redDWfQ== X-Google-Smtp-Source: AGHT+IGvJAcWikn/2GkAunTJp4wJjRX2y0XegrvA0YCLDSoXMGm33ouWPic5F/FBkAnJdnxZYF98SiNPybw= X-Received: from pjte14.prod.google.com ([2002:a17:90a:c20e:b0:33b:ca21:e3e7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3891:b0:32e:9da9:3e60 with SMTP id 98e67ed59e1d1-33bcf9375e8mr34102450a91.36.1761327908483; Fri, 24 Oct 2025 10:45:08 -0700 (PDT) Date: Fri, 24 Oct 2025 10:45:06 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <8ee16fbf254115b0fd72cc2b5c06d2ccef66eca9.1760731772.git.ackerleytng@google.com> <2457cb3b-5dde-4ca1-b75d-174b5daee28a@arm.com> Message-ID: Subject: Re: [RFC PATCH v1 07/37] KVM: Introduce KVM_SET_MEMORY_ATTRIBUTES2 From: Sean Christopherson To: Ackerley Tng Cc: Steven Price , cgroups@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, akpm@linux-foundation.org, binbin.wu@linux.intel.com, bp@alien8.de, brauner@kernel.org, chao.p.peng@intel.com, chenhuacai@kernel.org, corbet@lwn.net, dave.hansen@intel.com, dave.hansen@linux.intel.com, david@redhat.com, dmatlack@google.com, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, haibo1.xu@intel.com, hannes@cmpxchg.org, hch@infradead.org, hpa@zytor.com, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maobibo@loongson.cn, mathieu.desnoyers@efficios.com, maz@kernel.org, mhiramat@kernel.org, mhocko@kernel.org, mic@digikod.net, michael.roth@amd.com, mingo@redhat.com, mlevitsk@redhat.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, peterx@redhat.com, pgonda@google.com, prsampat@amd.com, pvorel@suse.cz, qperret@google.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, rostedt@goodmis.org, roypat@amazon.co.uk, rppt@kernel.org, shakeel.butt@linux.dev, shuah@kernel.org, suzuki.poulose@arm.com, tabba@google.com, tglx@linutronix.de, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, will@kernel.org, willy@infradead.org, wyihan@google.com, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com Content-Type: text/plain; charset="us-ascii" On Fri, Oct 24, 2025, Ackerley Tng wrote: > Sean Christopherson writes: > > @@ -486,6 +488,7 @@ struct kvm_vm *__vm_create(struct vm_shape shape, uint32_t nr_runnable_vcpus, > > } > > guest_rng = new_guest_random_state(guest_random_seed); > > sync_global_to_guest(vm, guest_rng); > > + sync_global_to_guest(vm, kvm_has_gmem_attributes); > > I ported this [1] except for syncing this value to the guest, because I > think the guest shouldn't need to know this information, KVM selftests are about practically and testing, what information should or shouldn't be available to a test from e.g. a safety perspective is completely irrelevant. In fact, one of the biggest advantages of selftests over KUT is that the guest side can know _exactly_ what's going on in the host. See the usage in 1850e3da4b03 ("KVM: selftests: Update private_mem_conversions_test to mmap() guest_memfd") from: https://github.com/sean-jc/linux.git x86/gmem_inplace > the host should decide what to do. I think, if the guests really need to know > this, the test itself can do the syncing. Why force tests to do extra work, and potentially introduce subtle bugs due to state being stale?