From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Joanne Koong <joannelkoong@gmail.com>,
brauner@kernel.org, bfoster@redhat.com, hch@infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iomap: rename bytes_pending/bytes_accounted to bytes_submitted/bytes_not_submitted
Date: Wed, 29 Oct 2025 01:36:51 -0700 [thread overview]
Message-ID: <aQHSI43zlNmALF1-@infradead.org> (raw)
In-Reply-To: <20251029055613.GQ4015566@frogsfrogsfrogs>
On Tue, Oct 28, 2025 at 10:56:13PM -0700, Darrick J. Wong wrote:
> On Tue, Oct 28, 2025 at 11:11:32AM -0700, Joanne Koong wrote:
> > As mentioned by Brian in [1], the naming "bytes_pending" and
> > "bytes_accounting" may be confusing and could be better named. Rename
> > this to "bytes_submitted" and "bytes_not_submitted" to make it more
> > clear that these are bytes we passed to the IO helper to read in.
> >
> > [1] https://lore.kernel.org/linux-fsdevel/aPuz4Uop66-jRpN-@bfoster/
> >
> > Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
>
> Looks fine to me, though it's gonna be hard for me to figure out what's
> going on in patch 2 because first I have to go find this 6.19 iomap
> branch that everyone's talking about...
https://web.git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=vfs-6.19.iomap
next prev parent reply other threads:[~2025-10-29 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 18:11 [PATCH v3 0/2] vfs-6.19.iomap commit 51311f045375 fixups Joanne Koong
2025-10-28 18:11 ` [PATCH v3 1/2] iomap: rename bytes_pending/bytes_accounted to bytes_submitted/bytes_not_submitted Joanne Koong
2025-10-29 5:56 ` Darrick J. Wong
2025-10-29 8:36 ` Christoph Hellwig [this message]
2025-10-29 8:37 ` Christoph Hellwig
2025-10-28 18:11 ` [PATCH v3 2/2] iomap: fix race when reading in all bytes of a folio Joanne Koong
2025-10-29 8:38 ` Christoph Hellwig
2025-10-31 20:34 ` Joanne Koong
2025-10-31 12:39 ` [PATCH v3 0/2] vfs-6.19.iomap commit 51311f045375 fixups Christian Brauner
2025-10-31 20:38 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQHSI43zlNmALF1-@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).