From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz
Subject: Re: [PATCH RFC 1/2] fs: do not pass a parameter for sync_inodes_one_sb()
Date: Mon, 3 Nov 2025 03:51:21 -0800 [thread overview]
Message-ID: <aQiXObERFgW3aVcE@infradead.org> (raw)
In-Reply-To: <8079af1c4798cb36887022a8c51547a727c353cf.1762142636.git.wqu@suse.com>
On Mon, Nov 03, 2025 at 02:37:28PM +1030, Qu Wenruo wrote:
> The function sync_inodes_one_sb() will always wait for the writeback,
> and ignore the optional parameter.
Indeed.
> Explicitly pass NULL as parameter for the call sites inside
> do_sync_work().
Note that this also kinda defeats having the two passes.
Te non-blocking sync seems to have gone away in:
b3de653105180b57af90ef2f5b8441f085f4ff56
Author: Jan Kara <jack@suse.cz>
Date: Tue Jul 3 16:45:30 2012 +0200
vfs: Reorder operations during sys_sync
(the argument was later briefly used for something else and that
then got reverted)
next prev parent reply other threads:[~2025-11-03 11:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 4:07 [PATCH RFC 0/2] fs: fully sync all fsese even for an emergency sync Qu Wenruo
2025-11-03 4:07 ` [PATCH RFC 1/2] fs: do not pass a parameter for sync_inodes_one_sb() Qu Wenruo
2025-11-03 11:51 ` Christoph Hellwig [this message]
2025-11-04 8:42 ` Jan Kara
2025-11-05 18:50 ` Daniel Vacek
2025-11-03 4:07 ` [PATCH RFC 2/2] fs: fully sync all fses even for an emergency sync Qu Wenruo
2025-11-03 11:56 ` Christoph Hellwig
2025-11-03 12:04 ` Christoph Hellwig
2025-11-03 20:46 ` Qu Wenruo
2025-11-03 20:55 ` Qu Wenruo
2025-11-04 8:28 ` Jan Kara
2025-11-04 8:39 ` Jan Kara
2025-11-05 11:32 ` Christian Brauner
2025-11-04 8:43 ` Qu Wenruo
2025-11-04 12:42 ` Jan Kara
2025-11-04 15:48 ` Christoph Hellwig
2025-11-03 16:00 ` [PATCH RFC 0/2] fs: fully sync all fsese " Askar Safin
2025-11-05 11:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQiXObERFgW3aVcE@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).