From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] iomap: replace folio_batch allocation with stack allocation
Date: Wed, 12 Nov 2025 04:53:50 -0800 [thread overview]
Message-ID: <aRSDXpcrs7fZ_ggO@infradead.org> (raw)
In-Reply-To: <aRR_FdE96gzkskqP@bfoster>
On Wed, Nov 12, 2025 at 07:35:33AM -0500, Brian Foster wrote:
> Hmm.. well I never really loved the flag return (or the end return), but
> I wanted to make the iomap helper more consistent with the underlying
> filemap helper because I think that reduces unnecessary complexity.
Probably. But the weird filemap (in general, not just the helper)
calling convention of using page indices and non-inclusive ends doesn't
really help with making it useful for higher level code.
> I
> suppose we could also make the flags an out param and either return void
> or just pass through the filemap helper return (i.e. folio count)...
That would seem more logical to me. Besides not really liking the new
convention overly much (but that's a minor nitpick) my main issue was
that this was hidden in a functional change without any explanation.
prev parent reply other threads:[~2025-11-12 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 17:50 [PATCH] iomap: replace folio_batch allocation with stack allocation Brian Foster
2025-11-12 8:39 ` Christoph Hellwig
2025-11-12 12:35 ` Brian Foster
2025-11-12 12:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRSDXpcrs7fZ_ggO@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox