From: Dan Carpenter <dan.carpenter@linaro.org>
To: Luis Henriques <luis@igalia.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] fuse: Uninitialized variable in fuse_epoch_work()
Date: Mon, 24 Nov 2025 09:05:30 +0300 [thread overview]
Message-ID: <aSP1qs4SOHrDE0tO@stanley.mountain> (raw)
In-Reply-To: <87ms4ez7q4.fsf@wotan.olymp>
On Sat, Nov 22, 2025 at 10:23:31AM +0000, Luis Henriques wrote:
> On Fri, Nov 21 2025, Dan Carpenter wrote:
>
> > On Fri, Nov 21, 2025 at 01:53:48PM +0000, Luis Henriques wrote:
> >> On Fri, Nov 21 2025, Dan Carpenter wrote:
> >>
> >> > The "fm" pointer is either valid or uninitialized so checking for NULL
> >> > doesn't work. Check the "inode" pointer instead.
> >>
> >> Hmm? Why do you say 'fm' isn't initialised? That's what fuse_ilookup()
> >> is doing, isn't it?
> >>
> >
> > I just checked again on linux-next. fuse_ilookup() only initializes
> > *fm on the success path. It's either uninitialized or valid.
>
> Yikes! You're absolutely right, I'm sorry for replying without checking.
>
> Feel free to add my
>
> Reviewed-by: Luis Henriques <luis@igalia.com>
>
> Although I guess you're patch could also move the iput():
>
Yeah. Good point. It's cleaner that way. I've sent a v2.
regards,
dan carpenter
prev parent reply other threads:[~2025-11-24 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 13:34 [PATCH next] fuse: Uninitialized variable in fuse_epoch_work() Dan Carpenter
2025-11-21 13:53 ` Luis Henriques
2025-11-21 17:43 ` Dan Carpenter
2025-11-22 10:23 ` Luis Henriques
2025-11-24 6:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSP1qs4SOHrDE0tO@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@igalia.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).