Re: [PATCH v4 25/47] memfd: convert memfd_create() to FD_PREPARE()

[Mike Rapoport <rppt@kernel.org>]

On Sun, Nov 23, 2025 at 05:33:43PM +0100, Christian Brauner wrote:
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  mm/memfd.c | 29 +++++------------------------
>  1 file changed, 5 insertions(+), 24 deletions(-)
> 
> diff --git a/mm/memfd.c b/mm/memfd.c
> index 1d109c1acf21..2a6614b7c4ea 100644
> --- a/mm/memfd.c
> +++ b/mm/memfd.c
> @@ -470,9 +470,9 @@ SYSCALL_DEFINE2(memfd_create,
>  		const char __user *, uname,
>  		unsigned int, flags)
>  {
> -	struct file *file;
> -	int fd, error;
> -	char *name;
> +	char *name __free(kfree) = NULL;
> +	unsigned int fd_flags;
> +	int error;
>  
>  	error = sanitize_flags(&flags);
>  	if (error < 0)
> @@ -482,25 +482,6 @@ SYSCALL_DEFINE2(memfd_create,
>  	if (IS_ERR(name))
>  		return PTR_ERR(name);
>  
> -	fd = get_unused_fd_flags((flags & MFD_CLOEXEC) ? O_CLOEXEC : 0);
> -	if (fd < 0) {
> -		error = fd;
> -		goto err_free_name;
> -	}
> -
> -	file = alloc_file(name, flags);
> -	if (IS_ERR(file)) {
> -		error = PTR_ERR(file);
> -		goto err_free_fd;
> -	}
> -
> -	fd_install(fd, file);
> -	kfree(name);
> -	return fd;
> -
> -err_free_fd:
> -	put_unused_fd(fd);
> -err_free_name:
> -	kfree(name);
> -	return error;
> +	fd_flags = (flags & MFD_CLOEXEC) ? O_CLOEXEC : 0;
> +	return FD_ADD(fd_flags, alloc_file(name, flags));
>  }
> 
> -- 
> 2.47.3
> 

-- 
Sincerely yours,
Mike.