Re: [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and utf32_to_utf8()

Re: [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and utf32_to_utf8()

[Armin Wolf]

Am 26.11.25 um 22:12 schrieb Andy Shevchenko:

> On Wed, Nov 26, 2025 at 09:48:27PM +0100, Hans de Goede wrote:
>> <dropping the lists from the Cc>
>>
>> Hi Armin,
>>
>> I think you've gotten the To: and Cc: lists wrong for this one ?
> (Semi). The other part of the change is part of pending patches in PDx86.
> Two options:
> - apply now via PDx86 to make it consistent (personally my preference)
> - wait for rc1 and push via NLS maintainers / Andrew Morton.

I too would prefer option 1, but i just noticed that get_maintainer.pl does not suggest
the VFS maintainers when asking it about fs/nls/nls_base.c. I changed the MAINTAINERS entry
for "VFS and infrastructure" from fs/* to fs/ to also include all subdirectories below
fs/, and now get_maintainer.pl correctly suggests the VFS maintainers.

Should i send a patch for this too?

Thanks,
Armin Wolf

>> On 26-Nov-25 9:43 PM, Armin Wolf wrote:
>>> After commit 25524b619029 ("fs/nls: Fix utf16 to utf8 conversion"),
>>> the return values of utf8_to_utf32() and utf32_to_utf8() are
>>> inconsistent when encountering an error: utf8_to_utf32() returns -1,
>>> while utf32_to_utf8() returns errno codes. Fix this inconsistency
>>> by modifying utf8_to_utf32() to return errno codes as well.
>

Re: [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and utf32_to_utf8()

[Andy Shevchenko]

On Wed, Nov 26, 2025 at 11:45:57PM +0100, Armin Wolf wrote:
> Am 26.11.25 um 22:12 schrieb Andy Shevchenko:
> > On Wed, Nov 26, 2025 at 09:48:27PM +0100, Hans de Goede wrote:
> > > <dropping the lists from the Cc>
> > > 
> > > I think you've gotten the To: and Cc: lists wrong for this one ?
> > (Semi). The other part of the change is part of pending patches in PDx86.
> > Two options:
> > - apply now via PDx86 to make it consistent (personally my preference)
> > - wait for rc1 and push via NLS maintainers / Andrew Morton.
> 
> I too would prefer option 1, but i just noticed that get_maintainer.pl does not suggest
> the VFS maintainers when asking it about fs/nls/nls_base.c. I changed the MAINTAINERS entry
> for "VFS and infrastructure" from fs/* to fs/ to also include all subdirectories below
> fs/, and now get_maintainer.pl correctly suggests the VFS maintainers.
> 
> Should i send a patch for this too?

I don't think it's a good idea. VFS maintainers won't like to be "spammed" by
that. Probably NLS is handled by any maintainer or Andrew Morton, depending on
the case. Here we are totally fine to go via PDx86.

> > > On 26-Nov-25 9:43 PM, Armin Wolf wrote:
> > > > After commit 25524b619029 ("fs/nls: Fix utf16 to utf8 conversion"),
> > > > the return values of utf8_to_utf32() and utf32_to_utf8() are
> > > > inconsistent when encountering an error: utf8_to_utf32() returns -1,
> > > > while utf32_to_utf8() returns errno codes. Fix this inconsistency
> > > > by modifying utf8_to_utf32() to return errno codes as well.

-- 
With Best Regards,
Andy Shevchenko