From: Matthew Wilcox <willy@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: jack@suse.cz, Deepakkumar Karn <dkarn@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] fs/buffer: add alert in try_to_free_buffers() for folios without buffers
Date: Mon, 15 Dec 2025 14:10:08 +0000 [thread overview]
Message-ID: <aUAWwPWDq0GgAjnP@casper.infradead.org> (raw)
In-Reply-To: <20251215-zuckungen-autogramm-a0c4291e525b@brauner>
On Mon, Dec 15, 2025 at 03:07:35PM +0100, Christian Brauner wrote:
> On Thu, 11 Dec 2025 18:42:11 +0530, Deepakkumar Karn wrote:
> > try_to_free_buffers() can be called on folios with no buffers attached
> > when filemap_release_folio() is invoked on a folio belonging to a mapping
> > with AS_RELEASE_ALWAYS set but no release_folio operation defined.
> >
> > In such cases, folio_needs_release() returns true because of the
> > AS_RELEASE_ALWAYS flag, but the folio has no private buffer data. This
> > causes try_to_free_buffers() to call drop_buffers() on a folio with no
> > buffers, leading to a null pointer dereference.
> >
> > [...]
>
> Applied to the vfs-7.0.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-7.0.misc branch should appear in linux-next soon.
No, this is the wrong fix. Please drop.
next prev parent reply other threads:[~2025-12-15 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 18:02 [PATCH] fs/buffer: add alert in try_to_free_buffers() for folios without buffers Deepakkumar Karn
2025-12-11 9:23 ` Jan Kara
2025-12-11 13:12 ` [PATCH v2] " Deepakkumar Karn
2025-12-11 13:27 ` Jan Kara
2025-12-15 14:07 ` Christian Brauner
2025-12-15 14:10 ` Matthew Wilcox [this message]
2025-12-15 18:00 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUAWwPWDq0GgAjnP@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=dkarn@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox