From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Disseldorp <ddiss@suse.de>
Subject: Re: [PATCH v1 0/4] initramfs: get rid of custom hex2bin()
Date: Tue, 20 Jan 2026 14:46:54 +0200 [thread overview]
Message-ID: <aW95Pk3f0GGtyNrY@smile.fi.intel.com> (raw)
In-Reply-To: <20260120-umleiten-gehackt-abb27d77dd73@brauner>
On Tue, Jan 20, 2026 at 12:20:41PM +0100, Christian Brauner wrote:
> > Here is the refactoring to show that. This is assumed to go via PRINTK
> > tree.
>
> No, initramfs is maintained by the VFS and we already carry other patches.
If this applies cleanly, take them through it, I will be glad, thanks!
> If you want the kstrtox changes to go another route then I will take the
> first two changes in a stable branch that can be merged.
I am fine with this route as long as the custom approach is gone.
> > I have tested this on x86, but I believe the same result will be
> > on big-endian CPUs (I deduced that from how strtox() works).
>
> Did you rerun the kunit tests the original change was part of or did you
> do some custom testing?
I'm not sure I understand the point. There were no test cases added for
simple_strntoul() AFAICS. Did I miss anything?
(If I didn't that is the second point on why the patches didn't get enough
time for review and not every stakeholder seen them, usually we require
the test cases for new APIs.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 20:38 [PATCH v1 0/4] initramfs: get rid of custom hex2bin() Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 1/4] initramfs: Sort headers alphabetically Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 2/4] initramfs: Refactor to use hex2bin() instead of custom approach Andy Shevchenko
2026-01-20 20:12 ` David Disseldorp
2026-01-20 20:34 ` Andy Shevchenko
2026-01-20 21:00 ` David Disseldorp
2026-01-20 21:17 ` Andy Shevchenko
2026-01-27 22:08 ` H. Peter Anvin
2026-01-19 20:38 ` [PATCH v1 3/4] vsprintf: Revert "add simple_strntoul" Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 4/4] kstrtox: Drop extern keyword in the simple_strtox() declarations Andy Shevchenko
2026-01-20 11:20 ` [PATCH v1 0/4] initramfs: get rid of custom hex2bin() Christian Brauner
2026-01-20 12:46 ` Andy Shevchenko [this message]
2026-01-23 12:22 ` Christian Brauner
2026-01-23 14:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW95Pk3f0GGtyNrY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ddiss@suse.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox