Re: [PATCH V3 02/21] dax: add fsdev.c driver for fs-dax on character dax

[Gregory Price <gourry@gourry.net>]

On Thu, Jan 08, 2026 at 03:15:10PM -0600, John Groves wrote:
> On 26/01/08 09:12AM, John Groves wrote:
> > On 26/01/08 11:31AM, Jonathan Cameron wrote:
> > > On Wed,  7 Jan 2026 09:33:11 -0600
> > > John Groves <John@Groves.net> wrote:
> 
> [ ... ]
> 
> > > > diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> > > > index d656e4c0eb84..491325d914a8 100644
> > > > --- a/drivers/dax/Kconfig
> > > > +++ b/drivers/dax/Kconfig
> > > > @@ -78,4 +78,21 @@ config DEV_DAX_KMEM
> > > >  
> > > >  	  Say N if unsure.
> > > >  
> > > > +config DEV_DAX_FS
> > > > +	tristate "FSDEV DAX: fs-dax compatible device driver"
> > > > +	depends on DEV_DAX
> > > > +	default DEV_DAX
> > > 
> > > What's the logic for the default? Generally I'd not expect a
> > > default for something new like this (so default of default == no)
> > 
> > My thinking is that this is harmless unless you use it, but if you
> > need it you need it. So defaulting to include the module seems
> > viable.
> > 
> > [ ... ]
> 
> On further deliberation, I think I'd like to get rid of 
> CONFIG_DEV_DAX_FS, and just include the fsdev_dax driver if DEV_DAX
> and FS_DAX are configured. Then CONFIG_FUSE_FAMFS_DAX (controlling the
> famfs code in fuse) can just depend on DEV_DAX, FS_DAX and FUSE_FS. 
> 
> That's where I'm leaning for the next rev of the series...
> 
> John
>

Please do that for CXL_DAX or whatever because it's really annoying to
have CXL and DAX configured but not have your dax device show up because
CXL_DAX wasn't configured.

:P

~Gregory