From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Disseldorp <ddiss@suse.de>
Cc: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] initramfs_test: test header fields with 0x hex prefix
Date: Wed, 21 Jan 2026 00:18:31 +0200 [thread overview]
Message-ID: <aW__NwDBkzq_bePk@smile.fi.intel.com> (raw)
In-Reply-To: <20260120204715.14529-3-ddiss@suse.de>
On Wed, Jan 21, 2026 at 07:32:33AM +1100, David Disseldorp wrote:
> cpio header fields are 8-byte hex strings, but one "interesting"
> side-effect of our historic simple_str[n]toul() use means that a "0x"
> prefixed header field will be successfully processed when coupled
> alongside a 6-byte hex remainder string.
Should mention that this is against specifications.
> Test for this corner case by injecting "0x" prefixes into the uid, gid
> and namesize cpio header fields. Confirm that init_stat() returns
> matching uid and gid values.
This is should be considered as an invalid case and I don't believe
we ever had that bad header somewhere. The specification is clear
that the number has to be filled with '0' to the most significant
byte until all 8 positions are filled.
If any test case like this appears it should not be fatal.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 20:32 [PATCH 0/2] initramfs_test: test header fields with 0x hex prefix David Disseldorp
2026-01-20 20:32 ` [PATCH 1/2] initramfs_test: add fill_cpio() format parameter David Disseldorp
2026-01-21 13:17 ` Andy Shevchenko
2026-01-20 20:32 ` [PATCH 2/2] initramfs_test: test header fields with 0x hex prefix David Disseldorp
2026-01-20 22:18 ` Andy Shevchenko [this message]
2026-01-21 9:42 ` David Disseldorp
2026-01-21 13:15 ` Andy Shevchenko
2026-01-21 16:17 ` David Disseldorp
2026-01-21 16:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW__NwDBkzq_bePk@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brauner@kernel.org \
--cc=ddiss@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox