Linux filesystem development
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Zack Weinberg <zack@owlfolio.org>
Cc: Vincent Lefevre <vincent@vinc17.net>, Jan Kara <jack@suse.cz>,
	 Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	 Rich Felker <dalias@libc.org>,
	linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
	 GNU libc development <libc-alpha@sourceware.org>
Subject: Re: [RFC v1] man/man2/close.2: CAVEATS: Document divergence from POSIX.1-2024
Date: Fri, 23 Jan 2026 02:02:53 +0100	[thread overview]
Message-ID: <aXLGdWGTrYo1s6v7@devuan> (raw)
In-Reply-To: <1ec25e49-841e-4b04-911d-66e3b9ff4471@app.fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

Hi Zack,

On Thu, Jan 22, 2026 at 07:33:58PM -0500, Zack Weinberg wrote:
[...]

> This is a full top-to-bottom rewrite of the manpage; please speak
> up if you don't like any of my changes to any of it, not just the
> new stuff about delayed errors.  It's written in freeform text for
> ease of reading; I'll do proper troff markup after the text is
> finalized.  (Alejandro, do you have a preference between -man
> and -mdoc markup?)

Strong preference for man(7).

[...]
> ERRORS
>        EBADF  The fd argument was not a valid, open file descriptor.
> 
>        EINTR  The close() call was interrupted by a signal.
>               The file descriptor *may or may not* have been closed,
>               depending on the operating system.  See “Signals and
>               close(),” below.

Punctuation like commas should go outside of the quotes (yes, I know
some styles do that, but we don't).

[...]

> STANDARDS
>        POSIX.1-2024.
> 
> HISTORY
>        The close() system call was present in Unix V7.

That would be simply stated as:

	V7.

We could also document the first POSIX standard, as not all Unix APIs
were standardized at the same time.  Thus:

	V7, POSIX.1-1988.

Thanks!


Have a lovely night!
Alex

> 
>        POSIX.1-2024 clarified the semantics of delayed errors; prior
>        to that revision, it was unspecified whether a close() call
>        that returned a delayed error would close the file descriptor.
>        However, we are not aware of any systems where it didn’t.
> 
> SEE ALSO
>        close_range(2), fcntl(2), fsync(2), fdatasync(2), shutdown(2),
>        unlink(2), open(2), read(2), write(2), fopen(3), fclose(3)

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-01-23  1:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a5tirrssh3t66q4vpwpgmxgxaumhqukw5nyxd4x6bevh7mtuvy@wtwdsb4oloh4>
     [not found] ` <efaffc5a404cf104f225c26dbc96e0001cede8f9.1747399542.git.alx@kernel.org>
     [not found]   ` <20250516130547.GV1509@brightrain.aerifal.cx>
     [not found]     ` <20250516143957.GB5388@qaa.vinc17.org>
     [not found]       ` <20250517133251.GY1509@brightrain.aerifal.cx>
     [not found]         ` <5jm7pblkwkhh4frqjptrw4ll4nwncn22ep2v7sli6kz5wxg5ik@pbnj6wfv66af>
     [not found]           ` <8c47e10a-be82-4d5b-a45e-2526f6e95123@app.fastmail.com>
     [not found]             ` <20250524022416.GB6263@brightrain.aerifal.cx>
     [not found]               ` <1571b14d-1077-4e81-ab97-36e39099761e@app.fastmail.com>
     [not found]                 ` <20260120174659.GE6263@brightrain.aerifal.cx>
     [not found]                   ` <lhubjio5dsb.fsf@oldenburg.str.redhat.com>
     [not found]                     ` <20260120190010.GF6263@brightrain.aerifal.cx>
2026-01-20 20:05                       ` [RFC v1] man/man2/close.2: CAVEATS: Document divergence from POSIX.1-2024 Florian Weimer
2026-01-20 20:11                   ` Paul Eggert
2026-01-20 20:35                   ` Alejandro Colomar
2026-01-20 20:42                     ` Alejandro Colomar
2026-01-23  0:33                       ` Zack Weinberg
2026-01-23  1:02                         ` Alejandro Colomar [this message]
2026-01-23  1:38                           ` Al Viro
2026-01-23 14:44                             ` Alejandro Colomar
2026-01-23 14:05                           ` Zack Weinberg
2026-01-24 19:34                         ` The 8472
2026-01-24 21:39                           ` Rich Felker
2026-01-24 21:57                             ` The 8472
2026-01-25 15:37                               ` Zack Weinberg
2026-01-26  8:51                                 ` Florian Weimer
2026-01-26 12:15                                 ` Jan Kara
2026-01-26 13:53                                   ` The 8472
2026-01-26 15:56                                     ` Jan Kara
2026-01-26 16:43                                       ` Jeff Layton
2026-01-26 23:01                                         ` Trevor Gross
2026-01-27  0:49                                           ` Jeff Layton
2026-01-28 16:58                                             ` Zack Weinberg
2026-02-05  9:34                                               ` Jan Kara
2026-02-06 15:13         ` Vincent Lefevre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXLGdWGTrYo1s6v7@devuan \
    --to=alx@kernel.org \
    --cc=brauner@kernel.org \
    --cc=dalias@libc.org \
    --cc=jack@suse.cz \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=vincent@vinc17.net \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zack@owlfolio.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox