Linux filesystem development
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>,
	Piyush Patle <piyushpatle228@gmail.com>,
	brauner@kernel.org, djwong@kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+bd5ca596a01d01bfa083@syzkaller.appspotmail.com
Subject: Re: [PATCH] iomap: handle iterator position advancing beyond current mapping
Date: Mon, 2 Feb 2026 13:34:11 -0500	[thread overview]
Message-ID: <aYDuI3EqwCmnc9uq@bfoster> (raw)
In-Reply-To: <aYDLXHqHmkdTL-M0@infradead.org>

On Mon, Feb 02, 2026 at 08:05:48AM -0800, Christoph Hellwig wrote:
> On Mon, Feb 02, 2026 at 03:35:39PM +0000, Matthew Wilcox wrote:
> > On Mon, Feb 02, 2026 at 06:48:50AM -0800, Christoph Hellwig wrote:
> > > On Mon, Feb 02, 2026 at 06:30:44PM +0530, Piyush Patle wrote:
> > > > Closes: https://syzkaller.appspot.com/bug?id=bd5ca596a01d01bfa083
> > > 
> > > This link doesn't work.  And the commit log has zero details of what's
> > > happening either.
> > 
> > Looks like this one:
> > 
> > https://syzkaller.appspot.com/bug?extid=bd5ca596a01d01bfa083
> > 
> > but there's no reproducer.  Looks like it's through the blockdev rather
> > than a filesystem being involved.
> 
> Let's wait for a reproducer.  The fix looks incorrect for anything I
> could think of, so I'd rather fix a real bug.  Given that lack of
> reproducer I'm also not confident that it fixes anything.  The fact
> that the Fixes tag points to a merge commit doesn't really increase
> the trust I have in it either.
> 
> 

+1 to this, FWIW. I've had that syzbot report marked in my inbox
expecting (hoping..) it would eventually spit out a reproducer to help
better characterize the cause.

This patch just appears to copy the warning check and force a lookup
cycle before we trigger it, which I don't think is doing us any favors.
At minimum we should have an understanding of precisely how this
happens.

Brian


  reply	other threads:[~2026-02-02 18:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 13:00 [PATCH] iomap: handle iterator position advancing beyond current mapping Piyush Patle
2026-02-02 14:48 ` Christoph Hellwig
2026-02-02 15:35   ` Matthew Wilcox
2026-02-02 16:05     ` Christoph Hellwig
2026-02-02 18:34       ` Brian Foster [this message]
2026-02-02 15:40 ` Piyush Patle
2026-02-02 15:44 ` Piyush Patle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYDuI3EqwCmnc9uq@bfoster \
    --to=bfoster@redhat.com \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=piyushpatle228@gmail.com \
    --cc=syzbot+bd5ca596a01d01bfa083@syzkaller.appspotmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox