From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <dgc@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz
Subject: Re: inconsistent lock state in the new fserror code
Date: Mon, 16 Feb 2026 21:47:45 -0800 [thread overview]
Message-ID: <aZQBAYCc5ouSoVXe@infradead.org> (raw)
In-Reply-To: <aY-n4leNi4NCzri1@dread>
On Sat, Feb 14, 2026 at 09:38:26AM +1100, Dave Chinner wrote:
> Yeah, that seems like a bug that needs fixing in the
> ioend_writeback_end_bio() function - if there's an IO error, it
> needs to punt the processing of the ioend to a workqueue...
The iomap code doesn't have a workqueue currently. The way we split
the code, we left the workqueue handling in XFS, because it is anchored
in the inode. I've been wanting to have it generic, as it would help
with various other things, though.
For XFS we might be able to just always hook into our I/O completion
handler and shortcut the workqueue for pure overwrites without errors,
but that won't help other users like the block device code, zonefs and
gfs2. Maybe we'll need an opt-in for the fserror reporting now to
exclude them?
On something related, if we require a user context for fserror_report
anyway, there is no need for the workqueue bouncing in it.
next prev parent reply other threads:[~2026-02-17 5:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 6:15 inconsistent lock state in the new fserror code Christoph Hellwig
2026-02-13 16:00 ` Darrick J. Wong
2026-02-13 19:07 ` Darrick J. Wong
2026-02-13 22:38 ` Dave Chinner
2026-02-14 5:55 ` Darrick J. Wong
2026-02-17 5:47 ` Christoph Hellwig [this message]
2026-02-18 19:00 ` Darrick J. Wong
2026-02-19 5:53 ` Christoph Hellwig
2026-02-19 5:59 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZQBAYCc5ouSoVXe@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox