From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jann Horn <jannh@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] pidfd: add CLONE_PIDFD_AUTOKILL
Date: Mon, 23 Feb 2026 16:47:02 +0100 [thread overview]
Message-ID: <aZx2dlV9tJaL5gDG@redhat.com> (raw)
In-Reply-To: <20260223-work-pidfs-autoreap-v4-2-e393c08c09d1@kernel.org>
On 02/23, Christian Brauner wrote:
>
> @@ -2259,13 +2268,20 @@ __latent_entropy struct task_struct *copy_process(
> * if the fd table isn't shared).
> */
> if (clone_flags & CLONE_PIDFD) {
> - int flags = (clone_flags & CLONE_THREAD) ? PIDFD_THREAD : 0;
> + unsigned flags = PIDFD_STALE;
> +
> + if (clone_flags & CLONE_THREAD)
> + flags |= PIDFD_THREAD;
> + if (clone_flags & CLONE_PIDFD_AUTOKILL) {
> + task_set_no_new_privs(p);
> + flags |= PIDFD_AUTOKILL;
> + }
>
> /*
> * Note that no task has been attached to @pid yet indicate
> * that via CLONE_PIDFD.
> */
> - retval = pidfd_prepare(pid, flags | PIDFD_STALE, &pidfile);
> + retval = pidfd_prepare(pid, flags, &pidfile);
Confused... I think you also need to change pidfs_alloc_file() to restore
O_TRUNC after do_dentry_open() clears this flag? Just like it curently does
pidfd_file->f_flags |= (flags & PIDFD_THREAD);
?
Oleg.
next prev parent reply other threads:[~2026-02-23 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 10:44 [PATCH v4 0/4] pidfd: add CLONE_AUTOREAP and CLONE_PIDFD_AUTOKILL Christian Brauner
2026-02-23 10:44 ` [PATCH v4 1/4] clone: add CLONE_AUTOREAP Christian Brauner
2026-02-23 10:44 ` [PATCH v4 2/4] pidfd: add CLONE_PIDFD_AUTOKILL Christian Brauner
2026-02-23 15:47 ` Oleg Nesterov [this message]
2026-02-23 15:51 ` Oleg Nesterov
2026-02-23 17:05 ` pidfd && O_RDWR Oleg Nesterov
2026-02-23 18:14 ` David Laight
2026-02-23 19:21 ` Oleg Nesterov
2026-02-23 21:39 ` Christian Brauner
2026-02-24 9:43 ` David Laight
2026-02-24 10:17 ` Oleg Nesterov
2026-02-24 16:47 ` Christian Brauner
2026-02-23 10:45 ` [PATCH v4 3/4] selftests/pidfd: add CLONE_AUTOREAP tests Christian Brauner
2026-02-23 10:45 ` [PATCH v4 4/4] selftests/pidfd: add CLONE_PIDFD_AUTOKILL tests Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZx2dlV9tJaL5gDG@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox