From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3 0/8] iomap, xfs: improve zero range flushing and lookup
Date: Mon, 9 Mar 2026 23:45:04 -0700 [thread overview]
Message-ID: <aa-98KuvCPNUhtRE@infradead.org> (raw)
In-Reply-To: <20260309134506.167663-1-bfoster@redhat.com>
On Mon, Mar 09, 2026 at 09:44:58AM -0400, Brian Foster wrote:
> Christoph discovered a regression with zero range in zoned mode on v2 of
> the series. The problem is that the zoned mode iomap_begin() relied on
> the hole mapping flush to handle the case where writes are pending but
> blocks have not yet been mapped into the data fork for the first time.
> Patches 1-2 lift the flush into the begin handler, document the purpose,
> and clean up the logic a bit. They are inserted at the beginning of the
> series to avoid regression from removing the flush from iomap in patch
> 3, but ordering is not critical as zoned support is experimental.
Thanks! I've run this through my usual zoned testing over last night
and it passes without regression. I'll also add it to bigger automated
CI, but I expect it to do just fine there as well.
prev parent reply other threads:[~2026-03-10 6:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 13:44 [PATCH v3 0/8] iomap, xfs: improve zero range flushing and lookup Brian Foster
2026-03-09 13:44 ` [PATCH v3 1/8] xfs: fix iomap hole map reporting for zoned zero range Brian Foster
2026-03-09 17:11 ` Darrick J. Wong
2026-03-09 18:18 ` Brian Foster
2026-03-10 14:47 ` Darrick J. Wong
2026-03-10 6:45 ` Christoph Hellwig
2026-03-09 13:45 ` [PATCH v3 2/8] xfs: flush dirty pagecache over hole in zoned mode " Brian Foster
2026-03-09 17:22 ` Darrick J. Wong
2026-03-09 18:19 ` Brian Foster
2026-03-10 6:47 ` Christoph Hellwig
2026-03-10 14:48 ` Darrick J. Wong
2026-03-10 6:45 ` Christoph Hellwig
2026-03-09 13:45 ` [PATCH v3 3/8] iomap, xfs: lift zero range hole mapping flush into xfs Brian Foster
2026-03-09 17:40 ` Darrick J. Wong
2026-03-10 6:47 ` Christoph Hellwig
2026-03-09 13:45 ` [PATCH v3 4/8] xfs: flush eof folio before insert range size update Brian Foster
2026-03-09 17:32 ` Darrick J. Wong
2026-03-09 18:24 ` Brian Foster
2026-03-09 13:45 ` [PATCH v3 5/8] xfs: look up cow fork extent earlier for buffered iomap_begin Brian Foster
2026-03-09 13:45 ` [PATCH v3 6/8] xfs: only flush when COW fork blocks overlap data fork holes Brian Foster
2026-03-09 17:47 ` Darrick J. Wong
2026-03-09 13:45 ` [PATCH v3 7/8] xfs: replace zero range flush with folio batch Brian Foster
2026-03-09 17:48 ` Darrick J. Wong
2026-03-09 13:45 ` [PATCH v3 8/8] xfs: report cow mappings with dirty pagecache for iomap zero range Brian Foster
2026-03-09 17:56 ` Darrick J. Wong
2026-03-09 18:31 ` Brian Foster
2026-03-09 18:38 ` Darrick J. Wong
2026-03-10 6:50 ` Christoph Hellwig
2026-03-10 14:52 ` Darrick J. Wong
2026-03-10 14:59 ` Christoph Hellwig
2026-03-10 6:49 ` Christoph Hellwig
2026-03-10 6:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa-98KuvCPNUhtRE@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox