From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BFFE1C7B92 for ; Wed, 7 Aug 2024 09:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723023206; cv=none; b=jnuaRwMl0I9bxIJL46voYfx41JMS+VadS9zsbK8Wr8dxd5FhBWLwwwFYbUS2gvziUL5WJFDqq5zGkvlY+/tPu08KHXrUGaW+aiPlPjZMY93jPzsqQ9277jPYPt4yZ/xILmgNY2P2mqI3tqfAy+jCwEmP+F7/oB8M1i9KQl58JPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723023206; c=relaxed/simple; bh=VXzHaQm7XQbvOf5JyZxW17M3OZXWaTO3C/rchFehAvk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f/Z0IyXJK3Vz+0i9eveN5YSwGOb/CCd8CWIdvGSrSWC5800DoyOf3iHsZ7KFs03cAydfNrEQhk7IOyUwI7IFHUbAVnJnAoWkz3Fj7O15Yp0po76dlS0RY8VenMV2saiFosWVAcv7v0b0DVQQSlvCjUoExc5/SWOzp/nqhqkpv9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hQ5OgiRf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hQ5OgiRf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723023203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r1ao3oI2bC/T6YUDOi/z140Hom9Lwuz/axm2MilPj98=; b=hQ5OgiRf/M4n7Aa7MKJzAZg7QCYvxhF34QLmdEJAbc3/CoTjBSwn6+jXdbY6tJBj9thUjj YTnWQtTmqZJ3g/DU3CGyyRCyuw6+l6vTw78lkJluwpJXm9+pZSiuLEH3UqS4SKEYIDr0IR WHYvd85S/SZgTTvHY0jsZj7wN87g0ww= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-pzVPuIT2Oe-XxXQ7rkiW8w-1; Wed, 07 Aug 2024 05:33:22 -0400 X-MC-Unique: pzVPuIT2Oe-XxXQ7rkiW8w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-427ffa0c9c7so17518345e9.1 for ; Wed, 07 Aug 2024 02:33:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723023201; x=1723628001; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=r1ao3oI2bC/T6YUDOi/z140Hom9Lwuz/axm2MilPj98=; b=rirlFULp0SCMowO8bSMB42AHKaXXtScmbVETJMP1VR1hrLfwc0B8shH1a4Ohe7ev4G HqqGM34Z2hA3LiQDr2m/B/znDMSUKRxhJFvnPmvbVoUvoIO80z1Q0R1wlozbD0em12nY WHABvcV4pcNa/SnSkOdx+4hBmkSVaj2z4xNivZmKrYf4kMPR6HdUtZJg8AE5Xd8IJjED kEsLeL+rE6QNQgDPpvVh+nNohYyJ6qKbhZhxCk/otYNYHYCGdWul7krbimd+A+g+/6eF wVUUwhjq9UNvuew0JonuMXz/dhCMxVabiP83sRGR4+ZRj6HCiXUGJUK2xLG5Emo0Wp1i QX9g== X-Forwarded-Encrypted: i=1; AJvYcCVx28xnkaTBGVUIekjq4B/o4T+Hwbc57mEMs6hNzMg/McXtNsOETvEyLnupE17ix9gztbvU/BIDXYDBwPkDsAZNG/FZY2qpGEKR8ppaeg== X-Gm-Message-State: AOJu0YwUn/Y52RCy9xo70NUiD2wUnor7SGe3YxsNvEZ1h8Op6ejPjZ4R 53Z0129D3+Z/IhwzNwL1VJXutLEX/QPD4paj2rwMof/Vei3BvcjQOmlkxJvxG8frJB9Dy7p7eQ9 H1U7/9nGgcNBeDNJLxVgiZ680bDr6jGoAvW9a8zhyeVTJC5yOkiBJYRDEcz/ISa3tPGGUvrc= X-Received: by 2002:a05:600c:1c25:b0:426:5520:b835 with SMTP id 5b1f17b1804b1-428e6af241dmr135922185e9.5.1723023200871; Wed, 07 Aug 2024 02:33:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZ1EiCG7QsRTDVlK5w+6p4nKm5oU+kZSr1yFuVMrc+A2gerQdJIOXN4JQj6G7CIHOFRMSO6g== X-Received: by 2002:a05:600c:1c25:b0:426:5520:b835 with SMTP id 5b1f17b1804b1-428e6af241dmr135921805e9.5.1723023200220; Wed, 07 Aug 2024 02:33:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:1a00:df86:93fe:6505:d096? (p200300cbc7081a00df8693fe6505d096.dip0.t-ipconnect.de. [2003:cb:c708:1a00:df86:93fe:6505:d096]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429059719ebsm19899155e9.18.2024.08.07.02.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Aug 2024 02:33:19 -0700 (PDT) Message-ID: Date: Wed, 7 Aug 2024 11:33:18 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 00/11] mm: replace follow_page() by folio_walk To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Jonathan Corbet , Christian Borntraeger , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Gerald Schaefer References: <20240802155524.517137-1-david@redhat.com> <20240807111534.4e79d7fd@p-imbrenda.boeblingen.de.ibm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240807111534.4e79d7fd@p-imbrenda.boeblingen.de.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.08.24 11:15, Claudio Imbrenda wrote: > On Fri, 2 Aug 2024 17:55:13 +0200 > David Hildenbrand wrote: > >> Looking into a way of moving the last folio_likely_mapped_shared() call >> in add_folio_for_migration() under the PTL, I found myself removing >> follow_page(). This paves the way for cleaning up all the FOLL_, follow_* >> terminology to just be called "GUP" nowadays. >> >> The new page table walker will lookup a mapped folio and return to the >> caller with the PTL held, such that the folio cannot get unmapped >> concurrently. Callers can then conditionally decide whether they really >> want to take a short-term folio reference or whether the can simply >> unlock the PTL and be done with it. >> >> folio_walk is similar to page_vma_mapped_walk(), except that we don't know >> the folio we want to walk to and that we are only walking to exactly one >> PTE/PMD/PUD. >> >> folio_walk provides access to the pte/pmd/pud (and the referenced folio >> page because things like KSM need that), however, as part of this series >> no page table modifications are performed by users. >> >> We might be able to convert some other walk_page_range() users that really >> only walk to one address, such as DAMON with >> damon_mkold_ops/damon_young_ops. It might make sense to extend folio_walk >> in the future to optionally fault in a folio (if applicable), such that we >> can replace some get_user_pages() users that really only want to lookup >> a single page/folio under PTL without unconditionally grabbing a folio >> reference. >> >> I have plans to extend the approach to a range walker that will try >> batching various page table entries (not just folio pages) to be a better >> replace for walk_page_range() -- and users will be able to opt in which >> type of page table entries they want to process -- but that will require >> more work and more thoughts. >> >> KSM seems to work just fine (ksm_functional_tests selftests) and >> move_pages seems to work (migration selftest). I tested the leaf >> implementation excessively using various hugetlb sizes (64K, 2M, 32M, 1G) >> on arm64 using move_pages and did some more testing on x86-64. Cross >> compiled on a bunch of architectures. >> >> I am not able to test the s390x Secure Execution changes, unfortunately. > > The whole series looks good to me, but I do not feel confident enough > about all the folio details to actually r-b any of the non-s390 > patches. (I do have a few questions, though) > > As for the s390 patches: they look fine. I have tested the series on > s390 and nothing caught fire. > > We will be able to get more CI coverage once this lands in -next. Thanks for the review! Note that it's already in -next. -- Cheers, David / dhildenb