From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D8136EA87 for ; Sat, 28 Feb 2026 12:38:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772282333; cv=none; b=fhswNSJ9y2ssqAI0n19cROHzb9AcMONzFIDzJ9LuqA9vY2uW0WuhWUEg2w1rzC3Mngz8xIZ1I82Ibol96iV3pg835mLCFDjwd4nBZSH2e5K1aTG+xj3p7TUvxzlmwocKDfMUPSi62Mi7MVTA2Z+Q2/uenjPgVTVebgC3Cy40nl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772282333; c=relaxed/simple; bh=PEA8vWjT5ovfF14s1Tw4RTm8694oQcfI75jIBt+A4lE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uUFAQrMbznzquWfBXmUV4QaTCInnF2qcv0nJ6dnk11jYGFx7astD1BBJczG3kj8y43rK73NS0GwNSn1550Bk0gb/wWD8WPaTHqF2ApI9+KM2Tb5vbDIjC4RMK8pSd8673aUemne1x29g03zOvfcG37lECCWb19JxeVVjSIqcR/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Mx+suYO4; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Mx+suYO4" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-48378df3469so19515315e9.1 for ; Sat, 28 Feb 2026 04:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772282330; x=1772887130; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mOaqhQImVlbU+bIaPkzVliN+MSpqLdHsMK4C5p4HbTE=; b=Mx+suYO4WAm6Esi84MZAoAmYsEg+faHqpOo9+bFiEOnlJdfwT+vS7ye5q++/MXA6g4 mTIXqomnM6dz7b4tpK1KbP9UZmW5hzlb/wweLxY7zC8AbdZzTDy3F/KaN2VMw1wXsB66 IAC4aSt0G9xxuaODA2KLVyEhRLb0dYJmfeWOOZXWzZ3Tj7iGwN4DH5r8OirXx5emK83X hFC6Ge2zWg/fc7qE1q3VrENHESF+g8ifwk+SOkHMggXufiEcnyLhtXrm+uV2F1gK9IJW /vh/E8zN7TllRgrU9JQ7pdZHtwYv695+yKsE8ye6vRoR2MHRk0HW1MoBXpi7GyXxLEJ7 t7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772282330; x=1772887130; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mOaqhQImVlbU+bIaPkzVliN+MSpqLdHsMK4C5p4HbTE=; b=ZukDpyLxwxJYmzxORayMWhQtz6mfZrF6QJ9RcMnknXbmkLfN+krZMXm5SfXkPYbRRz 5khL8pB4WltpVIcDkq0WG4FYQFcWeSHO3519SKnlUDOVQEZGcjB2h3r6nFeVydKfvhYw ScLLvvKsG6rtWk7/yei5fR6vBs7qORGFZZLdPzw/e3vHAznBv+IgbGbSnQBZ48Z15glt l+jyQ9lQqfXEQsK1k8jtd9wn0i+7woQAO+ZcgIeA/2qjvsYmSUMY85inu6I+G6Xh/Ccg +u4O5Fm9iAAdUl3s4Gvjz3Q6/brXTdtxC3CjYFiJOr0Utm+CT1okMNhOFB8WG7la09sB tq3A== X-Forwarded-Encrypted: i=1; AJvYcCWk+dTN5OZDe1v7JtADpv7ff7/nVd5pAXNtt1KOUDvMGSiUeuNYg11pU3cfTpWGShXvdHELe7Dod+DndpXk@vger.kernel.org X-Gm-Message-State: AOJu0Yw2Jcsu1HCoV+GooG37i2vONjzUmWjMjR34WKWJBRNXgQtWNVfk kzE55SVjNN9LaBNrAT4lEryruk0JA6f3ALcyTSzNinGER44f+1xxIj0ChsoFxldliOSxxRs+89i dngcwf+g8+DJBh5/58Q== X-Received: from wmby19.prod.google.com ([2002:a05:600c:c053:b0:480:690c:88de]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8b5b:b0:481:a662:b3f3 with SMTP id 5b1f17b1804b1-483c990c263mr116931775e9.7.1772282329804; Sat, 28 Feb 2026 04:38:49 -0800 (PST) Date: Sat, 28 Feb 2026 12:38:48 +0000 In-Reply-To: <20260227200848.114019-3-david@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Fri, Feb 27, 2026 at 09:08:33PM +0100, David Hildenbrand (Arm) wrote: > Nobody except memory.c should really set that parameter to non-NULL. So > let's just drop it and make unmap_mapping_range_vma() use > zap_page_range_single_batched() instead. > > Signed-off-by: David Hildenbrand (Arm) > diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > index da21d65ccd20..b8e59e4420f3 100644 > --- a/rust/kernel/mm/virt.rs > +++ b/rust/kernel/mm/virt.rs > @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > // sufficient for this method call. This method has no requirements on the vma flags. The > // address range is checked to be within the vma. > unsafe { > - bindings::zap_page_range_single(self.as_ptr(), address, size, core::ptr::null_mut()) > + bindings::zap_page_range_single(self.as_ptr(), address, size) > }; Please run rustfmt on Rust changes. Here, rustfmt leads to this being formatted on a single line: unsafe { bindings::zap_page_range_single(self.as_ptr(), address, size) }; with the above changed: Acked-by: Alice Ryhl # Rust and Binder Alice