From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A9743C052 for ; Sat, 28 Feb 2026 12:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772282672; cv=none; b=RrsfxEj2K30ILsM6ckmX2VnO9viVg1o1ie0CZBkuE5xBB9D+opiPJ0ssaFiRjfyNdJfJ1V+5eVSnPIgEYyyzeVLloyCQkB+ucQutq387xrNOwGsa431J7iZAho+8hIdcf+ap4OUDfJlrtGRAJ8io7CqmxJME9e8/f2jxqSPP48E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772282672; c=relaxed/simple; bh=tFmr9Byzvb8HJGLej5py8cdOGPaTsp9oa5qHurqtjoY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tt4dDRRY0xH0K+EGTeK29bj/yVtZLz/MCUaJEU5LkPr0L0Tt2xq/gOWyhkwkB6Tv4SpaXY2kuUDeT7F63mHkB9JR76OUtiqn5mYtd9z8eED9Nt5jPhMuC32jlk8M/izTSZjsE7n+MUiIXSw3JDKDpGjg1C6B+oVLoUZkpbPwI9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eiIPwFYL; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eiIPwFYL" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4837c597cd5so16662425e9.3 for ; Sat, 28 Feb 2026 04:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772282669; x=1772887469; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RH0L9WD4/u9mQiuU+Jc2bLYt2zoxsRLi5sNyM2YzgMo=; b=eiIPwFYLYXBrQHNFhQU4sxt4bdchSZbQ0puZaLAQjjg8A9Odu3TFv1QEgkJEBK/yCk BitlkH+LB4jiAVgOUKCUYU/hCr7WCXGT5fvZI3okDXNtzs17DkiD793+5XSdRTCu2QiZ Xd1BpLe2o/3Fc3Lb1LFNT53cPNBgVkNDDr2VddntcNLiYr+4RJ5kj6GGIOntLiFZIfVM lhlJ/0jeFMh0qmFgv0oWQVJRlexVpR1VV7Rjf2renHY7f7jWAsYvXQMIK2ZzA0iL1XZI flwCa2xK+qbn9PgkWlCnXGh4KzNZq5BPj/c8K9+6Q7zIwAgsQQDJS8mUn+2gWYAmH7CL LzWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772282669; x=1772887469; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RH0L9WD4/u9mQiuU+Jc2bLYt2zoxsRLi5sNyM2YzgMo=; b=s47lY2m1jZd5Qyxi0QJsTa/sjjWlyiDc1bHU+G8SKQuNdBZGbbXUiUOGXIdpu224az XxzPPm7r8Sg/W91Phxyrryq6+yEy39PxU1FyPqt0KnBMwhplp4AK8N/5TbCAFyrMj6hp RsAae2tj3QPEIkAIc4T8VUuaxUPQIMpuddT7M3j42up8bMbtFp9CWNTNBaKLaPd9h4j4 r9+hDIMUZI6JA/gI6+xlvy9LP0MjO+E173/Rm9Xf+rPvbVak2Q5DHSGqpuZbFI3KeB3F KNceNSN9ZBD3vxDgfYZglMwPD+yqnrwONvpSeKD5Wz1wxiBsK0ZRsktIy/oPybP8Aly2 DY0g== X-Forwarded-Encrypted: i=1; AJvYcCXArxcndJiiZtCRL4v8ycX3GPj5mRWYAUPDUcRMa0PFRVs+91LEhbIsmS1gCvhgQWYgQzQ1MLwS4n0WFR3C@vger.kernel.org X-Gm-Message-State: AOJu0YyXgon/3C2chtzYaJNmac4YBK5NBefAl8syAyr/kzKafFAYQ30i Gda40f4pqj1/XFfSH7KcJid2hWxC/O5xNPPo71YBRzk+PaczNeYns+NyUvMyPkB09EOxGOS1Ctg xlR9ICnSgv90BE382vg== X-Received: from wmqi19.prod.google.com ([2002:a05:600c:3553:b0:483:6fe1:c054]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4fc8:b0:47b:e2a9:2bd7 with SMTP id 5b1f17b1804b1-483c9beaca0mr120569145e9.19.1772282668287; Sat, 28 Feb 2026 04:44:28 -0800 (PST) Date: Sat, 28 Feb 2026 12:44:27 +0000 In-Reply-To: <20260227200848.114019-15-david@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-15-david@kernel.org> Message-ID: Subject: Re: [PATCH v1 14/16] mm: rename zap_page_range_single() to zap_vma_range() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" On Fri, Feb 27, 2026 at 09:08:45PM +0100, David Hildenbrand (Arm) wrote: > diff --git a/drivers/android/binder/page_range.rs b/drivers/android/binder/page_range.rs > index fdd97112ef5c..2fddd4ed8d4c 100644 > --- a/drivers/android/binder/page_range.rs > +++ b/drivers/android/binder/page_range.rs > @@ -130,7 +130,7 @@ pub(crate) struct ShrinkablePageRange { > pid: Pid, > /// The mm for the relevant process. > mm: ARef, > - /// Used to synchronize calls to `vm_insert_page` and `zap_page_range_single`. > + /// Used to synchronize calls to `vm_insert_page` and `zap_vma_range`. > #[pin] > mm_lock: Mutex<()>, > /// Spinlock protecting changes to pages. > @@ -719,7 +719,7 @@ fn drop(self: Pin<&mut Self>) { > > if let Some(vma) = mmap_read.vma_lookup(vma_addr) { > let user_page_addr = vma_addr + (page_index << PAGE_SHIFT); > - vma.zap_page_range_single(user_page_addr, PAGE_SIZE); > + vma.zap_vma_range(user_page_addr, PAGE_SIZE); > } LGTM. Be aware that this will have a merge conflict with patches currently in char-misc-linus that are scheduled to land in an -rc. > diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c > index dd2046bd5cde..e4488ad86a65 100644 > --- a/drivers/android/binder_alloc.c > +++ b/drivers/android/binder_alloc.c > @@ -1185,7 +1185,7 @@ enum lru_status binder_alloc_free_page(struct list_head *item, > if (vma) { > trace_binder_unmap_user_start(alloc, index); > > - zap_page_range_single(vma, page_addr, PAGE_SIZE); > + zap_vma_range(vma, page_addr, PAGE_SIZE); > > trace_binder_unmap_user_end(alloc, index); LGTM. > diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > index b8e59e4420f3..04b3cc925d67 100644 > --- a/rust/kernel/mm/virt.rs > +++ b/rust/kernel/mm/virt.rs > @@ -113,7 +113,7 @@ pub fn end(&self) -> usize { > /// kernel goes further in freeing unused page tables, but for the purposes of this operation > /// we must only assume that the leaf level is cleared. > #[inline] > - pub fn zap_page_range_single(&self, address: usize, size: usize) { > + pub fn zap_vma_range(&self, address: usize, size: usize) { > let (end, did_overflow) = address.overflowing_add(size); > if did_overflow || address < self.start() || self.end() < end { > // TODO: call WARN_ONCE once Rust version of it is added > @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > // sufficient for this method call. This method has no requirements on the vma flags. The > // address range is checked to be within the vma. > unsafe { > - bindings::zap_page_range_single(self.as_ptr(), address, size) > + bindings::zap_vma_range(self.as_ptr(), address, size) > }; > } Same as previous patch: please run rustfmt. It will format on a single line, like this: unsafe { bindings::zap_vma_range(self.as_ptr(), address, size) }; with the above change applied: Acked-by: Alice Ryhl # Rust and Binder Alice