From: Horst Birthelmer <horst@birthelmer.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Bernd Schubert <bschubert@ddn.com>,
Joanne Koong <joannelkoong@gmail.com>,
Horst Birthelmer <horst@birthelmer.com>,
Luis Henriques <luis@igalia.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Horst Birthelmer <hbirthelmer@ddn.com>
Subject: Re: Re: [PATCH v6 3/3] fuse: add an implementation of open+getattr
Date: Tue, 3 Mar 2026 11:38:57 +0100 [thread overview]
Message-ID: <aaa4oXWKKaaY2RJW@fedora.fritz.box> (raw)
In-Reply-To: <CAJfpegtTdL5Sxjtm3cKu9ZuYwceCfa2bX15Q3Wr_GQ2JNb84EA@mail.gmail.com>
On Tue, Mar 03, 2026 at 11:03:14AM +0100, Miklos Szeredi wrote:
> On Tue, 3 Mar 2026 at 06:06, Darrick J. Wong <djwong@kernel.org> wrote:
> >
> > On Mon, Mar 02, 2026 at 09:03:26PM +0100, Bernd Schubert wrote:
> > >
> > > On 3/2/26 19:56, Joanne Koong wrote:
>
> > > > The overhead for the server to fetch the attributes may be nontrivial
> > > > (eg may require stat()). I really don't think we can assume the data
> > > > is locally cached somewhere. Why always compound the getattr to the
> > > > open instead of only compounding the getattr when the attributes are
> > > > actually invalid?
> > > >
> > > > But maybe I'm wrong here and this is the preferable way of doing it.
> > > > Miklos, could you provide your input on this?
>
> Yes, it makes sense to refresh attributes only when necessary.
>
OK, I will add a 'compound flag' for optional operations and don't
execute those, when the fuse server does not support compounds.
This way we can always send the open+getattr, but if the fuse server
does not process this as a compound (aka. it would be costly to do it),
we only resend the FUSE_OPEN. Thus the current behavior does not change
and we can profit from fuse servers that actually have the possibility to
give us the attributes.
We can take a look at when to fetch the attributes in another context for
the other cases.
>
> Thanks,
> Miklos
>
Thanks,
Horst
next prev parent reply other threads:[~2026-03-03 10:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 16:43 [PATCH v6 0/3] fuse: compound commands Horst Birthelmer
2026-02-26 16:43 ` [PATCH v6 1/3] fuse: add compound command to combine multiple requests Horst Birthelmer
2026-02-26 23:05 ` Joanne Koong
2026-02-27 9:45 ` Miklos Szeredi
2026-02-27 10:48 ` Horst Birthelmer
2026-02-27 11:29 ` Miklos Szeredi
2026-02-27 11:37 ` Horst Birthelmer
2026-02-27 11:58 ` Miklos Szeredi
2026-03-02 9:56 ` Horst Birthelmer
2026-03-02 11:03 ` Miklos Szeredi
2026-03-02 13:19 ` Horst Birthelmer
2026-03-02 13:30 ` Miklos Szeredi
2026-03-06 14:27 ` Horst Birthelmer
2026-02-26 16:43 ` [PATCH v6 2/3] fuse: create helper functions for filling in fuse args for open and getattr Horst Birthelmer
2026-02-26 16:43 ` [PATCH v6 3/3] fuse: add an implementation of open+getattr Horst Birthelmer
2026-02-26 19:12 ` Joanne Koong
2026-02-27 7:48 ` Horst Birthelmer
2026-02-27 17:51 ` Joanne Koong
2026-02-27 18:07 ` Joanne Koong
2026-02-28 8:14 ` Horst Birthelmer
2026-03-02 18:56 ` Joanne Koong
2026-03-02 20:03 ` Bernd Schubert
2026-03-03 5:06 ` Darrick J. Wong
2026-03-03 7:26 ` Horst Birthelmer
2026-03-03 10:03 ` Miklos Szeredi
2026-03-03 10:38 ` Horst Birthelmer [this message]
2026-03-03 21:19 ` Joanne Koong
2026-03-04 9:11 ` Horst Birthelmer
2026-03-04 21:42 ` Joanne Koong
2026-03-03 23:13 ` Joanne Koong
2026-03-04 9:37 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa4oXWKKaaY2RJW@fedora.fritz.box \
--to=horst@birthelmer.de \
--cc=bschubert@ddn.com \
--cc=djwong@kernel.org \
--cc=hbirthelmer@ddn.com \
--cc=horst@birthelmer.com \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@igalia.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox