From: Alice Ryhl <aliceryhl@google.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: use simple_end_creating helper to consolidate fsnotify hooks
Date: Tue, 3 Mar 2026 15:01:11 +0000 [thread overview]
Message-ID: <aab3t00qpSBX1Gzg@google.com> (raw)
In-Reply-To: <20260302183741.1308767-3-amir73il@gmail.com>
On Mon, Mar 02, 2026 at 07:37:41PM +0100, Amir Goldstein wrote:
> Add simple_end_creating() helper which combines fsnotify_create/mkdir()
> hook and simple_done_creating().
>
> Use the new helper to consolidate this pattern in several pseudo fs
> which had open coded fsnotify_create/mkdir() hooks:
> binderfs, debugfs, nfsctl, tracefs, rpc_pipefs.
>
> For those filesystems, the paired fsnotify_delete() hook is already
> inside the library helper simple_recursive_removal().
>
> Note that in debugfs_create_symlink(), the fsnotify hook was missing,
> so the missing hook is fixed by this change.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Acked-by: Alice Ryhl <aliceryhl@google.com> # binderfs + rust_binderfs
next prev parent reply other threads:[~2026-03-03 15:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 18:37 [PATCH 0/2] fsnotify hooks consolidation Amir Goldstein
2026-03-02 18:37 ` [PATCH 1/2] fsnotify: make fsnotify_create() agnostic to file/dir Amir Goldstein
2026-03-02 18:37 ` [PATCH 2/2] fs: use simple_end_creating helper to consolidate fsnotify hooks Amir Goldstein
2026-03-02 22:28 ` Chuck Lever
2026-03-03 10:05 ` Amir Goldstein
2026-03-03 10:28 ` NeilBrown
2026-03-03 11:27 ` Amir Goldstein
2026-03-05 1:22 ` NeilBrown
2026-03-03 14:24 ` Chuck Lever
2026-03-03 15:01 ` Alice Ryhl [this message]
2026-03-03 12:45 ` [PATCH 0/2] fsnotify hooks consolidation Jeff Layton
2026-03-03 13:18 ` Amir Goldstein
2026-03-03 15:00 ` Christoph Hellwig
2026-03-03 15:05 ` Amir Goldstein
2026-03-03 15:07 ` Christoph Hellwig
2026-03-03 15:17 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab3t00qpSBX1Gzg@google.com \
--to=aliceryhl@google.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox