From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D58E1430BBA; Tue, 3 Mar 2026 14:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772548641; cv=none; b=GdAz3GzBupr4X2+MVXotwsFfccQ8LFCp9d1iTj7RFRCOqWoz205zYfTdUdbO3efOmloAoP73yIrbSqNAi9BNCkra4GF6sQRxzewqUZVamJirrIKf+8c5AUIQH11ECnKuR7FTNOeQqKDBZ2Ed01byo+6A8vnaRMxyACXVEOpo+AM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772548641; c=relaxed/simple; bh=jSW9+eytGEtkmitVtoPEoxlU0T6wDjF38zzCDPKXWFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lu1uB0aRtnsJrSQqKojXnvu7xFuNwpWTYdD+FBILWN3qALg8zSFyyC/1CAf0YQqoyUPcIZE0e5EpgjDGQHBUHaDwT4BmlpkeYrMwZ/qtdkHEBshnnoqltMLMlJ2FFoFBy4qvNhtcEkBrtz5Z/X3TNzgqWicEZMkfNkW4wOuG6dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sZF5C3Hh; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sZF5C3Hh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=srOioLdU+MhT/muNv5h0T5v0JdnOgAAc/XvQpD6hWps=; b=sZF5C3HhHt2xqO3P2+9FLeg67C 2LS909uYIig7JIA5ZDDdDoXuaC47rURaBqWQGZI1t6SXju2q8ZFv+GUdjGyVGKN/XR24jzbk3n88C UPGDCSFdqqdPw252SOvxznai7semOhP68884oeXUQx+TRELHqQk9F8BWQx1YiEhYpBaVEhKz05xze jzKYUaONemZCDcKZGC/SqZwE7EebHPnKMn6DEyH5JkvcoELcQqLFunWb+prUBpMeOMMzQXG43vzhm RcEC74u+O+Fq3R9jjrZ+2IY3B0I+dSJRCvdjYpqomO+sZx9KCpJ+SCxwvAkpUDGHrRQoG9Yhfa4ux aDHkYOSw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxQs1-0000000FL2X-1Fxn; Tue, 03 Mar 2026 14:37:09 +0000 Date: Tue, 3 Mar 2026 06:37:09 -0800 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 1/5] iomap, xfs: lift zero range hole mapping flush into xfs Message-ID: References: <20260129155028.141110-1-bfoster@redhat.com> <20260129155028.141110-2-bfoster@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Mar 02, 2026 at 02:02:10PM -0500, Brian Foster wrote: > I got a chance to look into this. Note that I don't reproduce a > generic/127 failure (even after running a few iters), so I don't know if > that might be related to something on your end. I reproduce the other > two and those looked like straight failures to zero. From that I think > the issue is just that xfs_zoned_buffered_write_iomap_begin() minimally > needs the flush treatment from patch 1. I.e., something like the > appended diff allows these tests to pass with -rzoned=1. > > Technically this could use the folio batch helper, but given that we > don't use that for the unwritten case (and thus already rely on the > iomap flush), and that this is currently experimental, I think this is > probably fine for now. Perhaps if we lift zeroing off into its own set > of callbacks, that might be a good opportunity to clean this up in both > places. Note that unwritten extents aren't supported for zoned rt inodes, so that case doesn't actually exist. The changes themselves look good. I kinda hate the very deep indentation, but I can't really see a good way to fix that easily.