From: Hyunchul Lee <hyc.lee@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Viacheslav Dubeyko <slava@dubeyko.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yangtao Li <frank.li@vivo.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
cheol.lee@lge.com
Subject: Re: [PATCH] hfsplus: limit sb_maxbytes to partition size
Date: Thu, 5 Mar 2026 08:49:58 +0900 [thread overview]
Message-ID: <aajFJu2ev6hAHKuA@hyunchul-PC02> (raw)
In-Reply-To: <aaguv09zaPCgdzWO@infradead.org>
On Wed, Mar 04, 2026 at 05:08:15AM -0800, Christoph Hellwig wrote:
> On Tue, Mar 03, 2026 at 05:28:07PM +0900, Hyunchul Lee wrote:
> > s_maxbytes currently is set to MAX_LFS_FILESIZE,
> > which allows writes beyond the partition size.
>
> The "partition size" does not matter here. s_maxbytes is the maximum
> size supported by the format and has nothing to do with the actual space
> allocated to the file system (which in Linux terminology would be the
> block device and not the partition anyway).
>
> >
> > As a result,
> > large-offset writes on small partitions can fail late
> > with ENOSPC.
>
> That sounds like some other check is missing in hfsplus, but it
> should be about the available free space, not the device size.
>
When running xfs_io -c "pwrite 8t 512", hfsplus fills the block device
with zeros before returning ENOSPC. I was trying to fix this,
but as you mentioned, I will look for another solution.
Thank for your review and comments.
--
Thanks,
Hyunchul
prev parent reply other threads:[~2026-03-04 23:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:28 [PATCH] hfsplus: limit sb_maxbytes to partition size Hyunchul Lee
2026-03-04 13:08 ` Christoph Hellwig
2026-03-04 20:04 ` Viacheslav Dubeyko
2026-03-05 0:29 ` Hyunchul Lee
2026-03-05 0:46 ` Viacheslav Dubeyko
2026-03-05 1:52 ` Hyunchul Lee
2026-03-05 23:21 ` Viacheslav Dubeyko
2026-03-06 0:57 ` Hyunchul Lee
2026-03-06 1:23 ` Viacheslav Dubeyko
2026-03-06 2:05 ` Hyunchul Lee
2026-03-06 20:08 ` Viacheslav Dubeyko
2026-03-09 0:52 ` Hyunchul Lee
2026-03-09 19:47 ` Viacheslav Dubeyko
2026-03-09 23:25 ` Hyunchul Lee
2026-03-05 14:27 ` hch
2026-03-06 0:40 ` Hyunchul Lee
2026-03-04 23:49 ` Hyunchul Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aajFJu2ev6hAHKuA@hyunchul-PC02 \
--to=hyc.lee@gmail.com \
--cc=cheol.lee@lge.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox