From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F553C6A56; Thu, 5 Mar 2026 16:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772727064; cv=none; b=DBeFux/1U/sMrfLalTHv4mpaPyJdqTtFtA/DJ/+Is8E/0nHkpDZ24KHaAXd5zkbQ5dwy0K+XKvlTLu9jx+iml5s3YPUPrxmfglpUF4x6/XWLKLRgFEV3X+LEVvvhT9scTqBs3MU1yQsq0mM4vNb21WT4V5MIzhJ/OdwBB3iQgzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772727064; c=relaxed/simple; bh=c+XF/gvoMyEyFXDRT+OEPe0qB4DuBMo7dbhaPsROzIY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bYa807U5R/zmxSifePJYHhN3AIftY+0mX+21nnjiGhCZiT+wZnl9sgznEA8NN1vigjzkS9fZBq04UxGghBargeicwZjlixJBnRQTGJIRG1reVCxYV+8EQ+x4q2bD83BwXqZ2LqOCtDhI30jWf+UVNgzSL4QJzbGm6cQgkPUpvDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=yjVL1Ntr; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="yjVL1Ntr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MFIpugouuHXRFsRvT9wNIewar3/u3GJDhCgVJkRbu6c=; b=yjVL1Ntr+Feu0SE6A1Y8MgXXVS jKFTrwAwSmLhlDcfV0w4aaF1iTiIr3gk74FklUlqdXhhfehYHlCDFYPS8BU6xBZQLh0vZCRbl8LlZ 44LCWqnL3Ez+nnoV0eT0MPfN4pHD3GEQeGkXjM6XcMwAHZqj3unbaZn+7k7hvlKW/Z2YOMWoF3Rf2 xfOdUwYdrfxhvOOegHnpDBxJD06P6NUi7ZhYzM3kxnOaUa3NV17SZJVzQa/HDqVZkNYe4ahPed59G p1RtNJ1c+lFzg6cFjZYviIcWlCD6DO6IR6yD7Nm6id0Uddd1k3poQG8O2Hfwbl16RUNKU+VvtudC8 BsAvrRxA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyBHt-00000002Bbz-2EcM; Thu, 05 Mar 2026 16:10:57 +0000 Date: Thu, 5 Mar 2026 08:10:57 -0800 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 1/5] iomap, xfs: lift zero range hole mapping flush into xfs Message-ID: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Mar 05, 2026 at 10:06:35AM -0500, Brian Foster wrote: > Sure. I had reworked the latter part of the comment as well. With both > the changes it currently looks like: > > /* > * When zeroing, don't allocate blocks for holes as they are already > * zeroes, but we need to ensure that no extents exist in both the data overly long line here > * submission but doesn't remap into the data fork until completion. If and here. Otherwise looks great.