From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8732D876B for ; Fri, 6 Mar 2026 00:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772757622; cv=none; b=kkljQDHTAq242iYob0KOdaLwMO9ICSeYf7b6Hb182/nP6dwFjG1lASoiK/gw+0EwPSMxDiynPygq8C8HC96umWZN//v8OwXwPRWBqNfejnULltWW7Zc3tYDE4v+c+AYa5ogUnzFbrJVUPTF1E7uvEZhATxcnBaWt6hRDrXSxxP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772757622; c=relaxed/simple; bh=jGeYHXh3LlQv45gi9ZQhGp4yio/AGub7iPItilfYkQw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p5D3UqdF/01ZxYwOiSx9xmKFj0Q6cpwgzceDODoHOgma6hrolWiArIFU/eaMPOyQSPGNYFqUGAwx85diQH5cgmvgq/Ab4M8ZOjKwmva1Qeqbvsmk9lBCJ/PFAlv71p9s23IonPcqT+Rr15apMQS+IghyhRRjKa1v5WmrTqxs36E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKkm3pnq; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKkm3pnq" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82418b0178cso4867225b3a.1 for ; Thu, 05 Mar 2026 16:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772757620; x=1773362420; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Vwm3wwvpSH+RZbikS9WmeaWeWABu5ZF4Jeo4IRWuDNQ=; b=SKkm3pnqrONZcf3GIeifQ7+UrEb7eTV+U5vW/z38cm3jO5qEj04huTGCMu/OK1yk8I SQtI1MNtP4k9YMJ2K0vgOvoScrWY3xdhc7vvjbevVLEPc5LmRDU4FJxm8U0tumeLDtcn FRL1k6XITPzcUPaes6TXcI9sgb4Cv0JwngTmh6rlSNuR602spK/R+dyDz2nF+7OaR1iD 9RUYEGJj8/jKlllfBtMOtXJXLASerAJItIhHRLVvB6P7RaHo4uDbDhKy9UcAXTjWOwr/ 9uE0hwFdw4ZIhYItwESX7Ytvko7MXMllqf7B/RExJgxpSFfBy8UUYjjOkdCYDn7a25JV GNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772757620; x=1773362420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vwm3wwvpSH+RZbikS9WmeaWeWABu5ZF4Jeo4IRWuDNQ=; b=xPnsuqSOPQaj+AYytTHUXc27AGGPy5sZMNdh3I8QfZn5WTCyqgKtmfpPtr97DUqbRE WwzqemlD/Riq8ueqmk4aD3IHpkidz7/UPhjtPgxsN0eJF9jFL3pDaL2cITFU/S1v8qSO GVTUEzFC5qhyJIcKroM3iYcMhQKFVe74Isbe1Mcs53me2PDex0XEDqENZ4F5WrxsVhmm ZPvfancBjixd5yNhYyXmMhn49tZbzhopAg3vm+s0krmz0ChZ/WXlWjgeWs3UUPss3DQr r1+aZcZUkrENtYZsnErvW+avzkGmAKvfihPPwBOu1ZxB6axMreNE6PZpS20jQumT2dpK V3oQ== X-Forwarded-Encrypted: i=1; AJvYcCXlhb6YAUq6vi2jyoOLilQvwOJo366HRuVWNC/XREiNtTd4eTx35aYB3V8MMXRJskzW1bzhH4IZ2X5DGrYt@vger.kernel.org X-Gm-Message-State: AOJu0YztTqXWA2A1Avq4MMP1kTq7g8uY7mCj3aSSYPMh05aojZgmpB8j jKesqAQha7xUextAu5mAde+KeEpds9nCtRDQ7NT7VkCooye/vvZ9Rnmz X-Gm-Gg: ATEYQzz54npWVlBPL5Wpg6WGfo21h5TX3Sw9O/570nDNfqueXOpTkp+7zXpFLg5Lbew Y2hCbwh6hJvLOP1LXB3ds4iYORm2rh+WKySisavWPLVC4MuWsqK/tOHVAZ2FvqxzOzrWKDmJtet Y5klc9r0f5rYq+G9134UuswJ0P0trZGgpo7eeyb9DFtn3VhEDI88urXyW/5odV3cmjktoaY8GT3 E+xBPPB5Me5II1HOxqD4reZtl2lvVQz2cYZ1q93KtDHqH3OQmZXfCMzretV7uYC3OLJAoct/E9l Xi3pJ2nndT3BEx9ZaM/Nzm29JQuHY879RX2dsOSm53o6s7s7zw/C7SkOqNko4enE5UQTeROer5o YejbtLbTldByzUpsSFkSosqGs+Rxy1Ejy5r2YqOA9GQPsm0K5RxoabPluZUujtO91Oc6VeDQAaD +zYzgdTcJpG8PXKw== X-Received: by 2002:a05:6a00:9510:b0:81a:883d:cd05 with SMTP id d2e1a72fcca58-829a30d0307mr163580b3a.64.1772757620313; Thu, 05 Mar 2026 16:40:20 -0800 (PST) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01080fsm22107684b3a.46.2026.03.05.16.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 16:40:19 -0800 (PST) Date: Fri, 6 Mar 2026 09:40:17 +0900 From: Hyunchul Lee To: "hch@infradead.org" Cc: Viacheslav Dubeyko , "glaubitz@physik.fu-berlin.de" , "frank.li@vivo.com" , "slava@dubeyko.com" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cheol.lee@lge.com" Subject: Re: [PATCH] hfsplus: limit sb_maxbytes to partition size Message-ID: References: <20260303082807.750679-1-hyc.lee@gmail.com> <5c670210661f30038070616c65492fa2a96b028c.camel@ibm.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Mar 05, 2026 at 06:27:34AM -0800, hch@infradead.org wrote: > On Thu, Mar 05, 2026 at 09:29:33AM +0900, Hyunchul Lee wrote: > > Sorry it's generic/285, not generic/268. > > in generic/285, there is a test that creates a hole exceeding the block > > size and appends small data to the file. hfsplus fails because it fills > > the block device and returns ENOSPC. However if it returns EFBIG > > instead, the test is skipped. > > generic/285 needs to call _require_sparse_files. > The generic/258(src/seek_sanity_test.c) is considering filesystems that don't support sparse files[1]. int test_basic_support() ... pos = lseek(fd, 0, SEEK_HOLE); ... if (pos == filsze) { default_behavior = 1; fprintf(stderr, "File system supports the default behavior.\n"); ... The issue is that there are some tests which write to offsets larger than the block device. How about skipping for such test cases when dealing with filesystems that don't support sparse files? [1]: https://github.com/kdave/xfstests/blob/master/src/seek_sanity_test.c#L1244 -- Thanks, Hyunchul