From: Jeff Layton <jlayton@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>, ceph-devel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ceph_fill_trace(): add missing check in d_revalidate snapdir handling
Date: Wed, 30 Oct 2019 09:49:15 -0400 [thread overview]
Message-ID: <ab18543fbecfa6a6ac8003a9b506b74b1acddcab.camel@kernel.org> (raw)
In-Reply-To: <20191029135329.GI26530@ZenIV.linux.org.uk>
On Tue, 2019-10-29 at 13:53 +0000, Al Viro wrote:
> [resent to correct address]
>
> we should not play with dcache without parent locked...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index 9f135624ae47..c07407586ce8 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -1434,6 +1434,7 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req)
> dout(" final dn %p\n", dn);
> } else if ((req->r_op == CEPH_MDS_OP_LOOKUPSNAP ||
> req->r_op == CEPH_MDS_OP_MKSNAP) &&
> + test_bit(CEPH_MDS_R_PARENT_LOCKED, &req->r_req_flags) &&
> !test_bit(CEPH_MDS_R_ABORTED, &req->r_req_flags)) {
> struct inode *dir = req->r_parent;
>
Thanks Al.
Both patches merged and marked for stable. Ilya should send a PR to
Linus with these within the next week or so.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2019-10-30 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 13:53 [PATCH] ceph_fill_trace(): add missing check in d_revalidate snapdir handling Al Viro
2019-10-30 13:49 ` Jeff Layton [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-29 13:51 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab18543fbecfa6a6ac8003a9b506b74b1acddcab.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).