From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Bae Yeonju <iwasbaeyz@gmail.com>, stable <stable@kernel.org>,
Kees Cook <kees@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] adfs: validate nzones in adfs_read_map()
Date: Fri, 20 Mar 2026 16:02:53 +0000 [thread overview]
Message-ID: <ab1vrTs2k6Q9_lsy@shell.armlinux.org.uk> (raw)
In-Reply-To: <2026032021-renewable-control-9c81@gregkh>
On Fri, Mar 20, 2026 at 04:05:03PM +0100, Greg Kroah-Hartman wrote:
> But then why is this check also needed? I'm all for moving it
> elsewhere, Bae has the reproducer, they can check if moving it fixes
> their issue or not.
There are two variants of the disc format.
adfs_validate_bblk() which is used for hard disc formats where the
number of zones is greater than zero, and ADFS F format on floppy
disks which should have four zones.) This doesn't validate the
number of zones, but it should - and this is where it should be
added, not in the map reading code.
The other uses adfs_validate_dr0(), which is for the ADFS E floppy
format images. This already validates that the number of zones is
equal to one.
Reference:
https://www.riscosopen.org/wiki/documentation/show/FileCore%20Overview#laylogic
Only "new map" is supported by adfs under Linux.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2026-03-20 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 14:23 [PATCH] adfs: validate nzones in adfs_read_map() Greg Kroah-Hartman
2026-03-20 14:37 ` Russell King (Oracle)
2026-03-20 15:05 ` Greg Kroah-Hartman
2026-03-20 15:21 ` paeyz
2026-03-20 15:40 ` Greg KH
2026-03-20 15:52 ` [PATCH v2] adfs: validate nzones in adfs_validate_bblk() paeyz
2026-03-20 16:04 ` Greg KH
2026-03-20 16:08 ` Russell King (Oracle)
2026-03-20 16:11 ` Greg KH
2026-03-21 4:45 ` [PATCH v3] " paeyz
2026-03-20 16:05 ` [PATCH] adfs: validate nzones in adfs_read_map() Russell King (Oracle)
2026-03-20 16:02 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1vrTs2k6Q9_lsy@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=iwasbaeyz@gmail.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox