From: "Arnd Bergmann" <arnd@arndb.de>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: syzbot <syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
christian.brauner@ubuntu.com,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
jlayton@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
"Matthew Wilcox" <willy@infradead.org>,
ZhangPeng <zhangpeng362@huawei.com>,
"Viacheslav Dubeyko" <slava@dubeyko.com>,
linux-m68k@lists.linux-m68k.org
Subject: Re: [syzbot] [hfs?] WARNING in hfs_write_inode
Date: Wed, 04 Jan 2023 23:33:50 +0100 [thread overview]
Message-ID: <ab7a9477-ddc7-430f-b4ee-c67251e879b0@app.fastmail.com> (raw)
In-Reply-To: <CAHk-=wi8XyAUF9_z6-oa4Ava6PVZeE-=TVNcFK1puQHpOtqLLw@mail.gmail.com>
On Wed, Jan 4, 2023, at 20:06, Linus Torvalds wrote:
>
> I suspect this code is basically all dead. From what I can tell, hfs
> only gets updates for
>
> (a) syzbot reports
>
> (b) vfs interface changes
There is clearly no new work going into it, and most data exchange
with MacOS would use HFS+, but I think there are still some users.
> and the last real changes seem to have been by Ernesto A. Fernández
> back in 2018.
>
> Hmm. Looking at that code, we have another bug in there, introduced by
> an earlier fix for a similar issue: commit 8d824e69d9f3 ("hfs: fix OOB
> Read in __hfs_brec_find") added
>
> + if (HFS_I(main_inode)->cat_key.CName.len > HFS_NAMELEN)
> + return -EIO;
>
> but it's after hfs_find_init(), so it should actually have done a
> hfs_find_exit() to not leak memory.
>
> So we should probably fix that too.
>
> Something like this ENTIRELY UNTESTED patch?
>
> Do we have anybody who looks at hfs?
Adding Viacheslav Dubeyko to Cc, he's at least been reviewing
patches for HFS and HFS+ somewhat recently. The linux-m68k
list may have some users dual-booting old MacOS.
Viacheslav, see the start of the thread at
https://lore.kernel.org/lkml/000000000000dbce4e05f170f289@google.com/
Arnd
next prev parent reply other threads:[~2023-01-04 22:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:24 [syzbot] [hfs?] WARNING in hfs_write_inode syzbot
2023-01-04 14:43 ` Arnd Bergmann
2023-01-04 19:06 ` Linus Torvalds
2023-01-04 22:33 ` Arnd Bergmann [this message]
2023-01-04 22:42 ` John Paul Adrian Glaubitz
2023-01-05 0:36 ` Viacheslav Dubeyko
2023-01-05 4:37 ` Viacheslav Dubeyko
2023-01-05 15:46 ` Matthew Wilcox
2023-01-05 16:45 ` Viacheslav Dubeyko
2023-07-20 15:27 ` Dmitry Vyukov
2023-07-20 17:30 ` Matthew Wilcox
2023-07-20 17:50 ` John Paul Adrian Glaubitz
2023-07-20 17:59 ` Matthew Wilcox
2023-07-20 18:27 ` Jeff Layton
2023-07-20 22:20 ` Dave Chinner
2023-07-21 1:03 ` Finn Thain
2023-07-21 1:11 ` Matthew Wilcox
2023-07-21 1:25 ` Michael Schmitz
2023-07-21 1:45 ` Finn Thain
2023-07-21 6:42 ` Kirsten Bromilow
2023-07-21 8:14 ` Finn Thain
2023-07-21 13:10 ` Theodore Ts'o
2023-07-20 21:38 ` Jeffrey Walton
2023-07-20 22:37 ` Matthew Wilcox
2023-07-20 22:53 ` Linus Torvalds
2023-07-21 1:28 ` Mike Hosken
2023-07-20 17:56 ` John Paul Adrian Glaubitz
2023-07-20 19:05 ` Michael Schmitz
2023-07-21 5:07 ` John Paul Adrian Glaubitz
2023-07-21 5:40 ` Eric W. Biederman
2023-01-05 21:34 ` Michael Schmitz
2023-01-05 21:53 ` Linus Torvalds
2023-01-05 23:46 ` Michael Schmitz
2023-01-06 7:09 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab7a9477-ddc7-430f-b4ee-c67251e879b0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=slava@dubeyko.com \
--cc=syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).