From: Petr Mladek <pmladek@suse.com>
To: David Disseldorp <ddiss@suse.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 0/6] initramfs: test and improve cpio hex header validation
Date: Wed, 1 Apr 2026 14:58:31 +0200 [thread overview]
Message-ID: <ac0Wd1tmV0ndmE1-@pathway.suse.cz> (raw)
In-Reply-To: <20260331070519.5974-1-ddiss@suse.de>
On Tue 2026-03-31 17:57:30, David Disseldorp wrote:
> v5 changes:
> - rework 2/6 and 4/6 test comment, as suggested by Andy
> - 2/6: initialize struct kstat in tests to account for possible
> init_stat() failure
> + drop Andy's review tag due to this minor change
>
> ----------------------------------------------------------------
> v4: 20260329105307.2876-1-ddiss@suse.de
> - rework initramfs_test changes to use an inject_ox parameter instead of
> having tests pass through an unvalidated format string.
> + drop Andy's reviewed-by from 1/6 and 2/6 to account for changed test
> + 4/6 minor changes for test context and comment
> - add review tags for 3/6, 5/6 and 6/6 following list feedback
>
> ----------------------------------------------------------------
> v3: 20260323150054.3587083-1-andriy.shevchenko@linux.intel.com
>
> The series that introduced simple_strntoul() had passed into kernel
> without proper review and hence reinvented a wheel that's not needed.
> Here is the refactoring to show that. It can go via PRINTK or VFS
> tree.
>
> I have tested this on x86, but I believe the same result will be
> on big-endian CPUs (I deduced that from how strtox() works).
>
> I also run KUnit tests.
>
> Changelog v3:
> - rebased on top of latest kernel
> - squashed patches proposed by David
>
> v2: 20260121172749.32322-1-ddiss@suse.de
> v1: 20260119204151.1447503-1-andriy.shevchenko@linux.intel.com
>
> ----------------------------------------------------------------
> Andy Shevchenko (4):
> initramfs: Sort headers alphabetically
> initramfs: Refactor to use hex2bin() instead of custom approach
> vsprintf: Revert "add simple_strntoul"
> kstrtox: Drop extern keyword in the simple_strtox() declarations
>
> David Disseldorp (2):
> initramfs_test: add fill_cpio() inject_ox parameter
> initramfs_test: test header fields with 0x hex prefix
The patchset seems to be ready for linux-next. I could take it via
printk tree.
But I would like see an ACK from a VFS maintainer first.
Best Regards,
Petr
next prev parent reply other threads:[~2026-04-01 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 6:57 [PATCH v5 0/6] initramfs: test and improve cpio hex header validation David Disseldorp
2026-03-31 6:57 ` [PATCH v5 1/6] initramfs_test: add fill_cpio() inject_ox parameter David Disseldorp
2026-04-01 12:46 ` Petr Mladek
2026-03-31 6:57 ` [PATCH v5 2/6] initramfs_test: test header fields with 0x hex prefix David Disseldorp
2026-03-31 10:12 ` Andy Shevchenko
2026-04-01 12:47 ` Petr Mladek
2026-03-31 6:57 ` [PATCH v5 3/6] initramfs: Sort headers alphabetically David Disseldorp
2026-04-01 12:49 ` Petr Mladek
2026-03-31 6:57 ` [PATCH v5 4/6] initramfs: Refactor to use hex2bin() instead of custom approach David Disseldorp
2026-04-01 12:55 ` Petr Mladek
2026-03-31 6:57 ` [PATCH v5 5/6] vsprintf: Revert "add simple_strntoul" David Disseldorp
2026-03-31 6:57 ` [PATCH v5 6/6] kstrtox: Drop extern keyword in the simple_strtox() declarations David Disseldorp
2026-04-01 12:58 ` Petr Mladek [this message]
2026-04-09 8:48 ` [PATCH v5 0/6] initramfs: test and improve cpio hex header validation Andy Shevchenko
2026-04-09 13:35 ` Christian Brauner
2026-04-09 13:34 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac0Wd1tmV0ndmE1-@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brauner@kernel.org \
--cc=ddiss@suse.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox