From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories. Date: Mon, 25 May 2009 12:51:57 +0200 Message-ID: References: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> <1243169978.3502.7.camel@poy> <1243178448.4035.12.camel@poy> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" , stern To: "Eric W. Biederman" Return-path: Received: from mail-fx0-f168.google.com ([209.85.220.168]:36598 "EHLO mail-fx0-f168.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbZEYKxx convert rfc822-to-8bit (ORCPT ); Mon, 25 May 2009 06:53:53 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 25, 2009 at 09:53, Eric W. Biederman wrote: > ebiederm@xmission.com (Eric W. Biederman) writes: > Currently I expect that those attributes that are not deleted may > actually be bugs as well. =C2=A0If a driver manually adds sysfs files= after > device_create/device_register the uevent will have already been sent > and you can not safely use those attributes in when processing a hotp= lug > event. That's true, and would be good to fix. I guess we need to come up with a way of maintaining binary attributes in the same way as "default" attributes. Today they need to be created manually. Maybe we can get your patch series in, with the version that removes the files, but warns on existing directories, and work on fixing the users, and possible remove the deletion of files when we fixed all the current users? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html