From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Disseldorp <ddiss@suse.de>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 4/6] initramfs: Refactor to use hex2bin() instead of custom approach
Date: Mon, 30 Mar 2026 12:50:24 +0300 [thread overview]
Message-ID: <acpHYPiOy-S3PUNT@ashevche-desk.local> (raw)
In-Reply-To: <20260329105307.2876-5-ddiss@suse.de>
On Sun, Mar 29, 2026 at 09:30:26PM +1100, David Disseldorp wrote:
> There is a simple_strntoul() function used solely as a shortcut
> for hex2bin() with proper endianess conversions. Replace that
> and drop the unneeded function in the next changes.
>
> This implementation will abort if we fail to parse the cpio header,
> instead of using potentially bogus header values.
...
> /*
> * bogus newc header with "0x" prefixes on the uid, gid and namesize values.
> - * parse_header()/simple_str[n]toul() accept this.
> + * parse_header()/simple_str[n]toul() accepted this, contrary to the initramfs
> + * specification. hex2bin() now fails.
> */
> #define CPIO_HDR_OX_INJECT \
> "%s%08x%08x0x%06x0X%06x%08x%08x%08x%08x%08x%08x%08x0x%06x%08x%s"
I think this change should be in patch 1.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-30 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 10:30 [PATCH v4 0/6] initramfs: test and improve cpio hex header validation David Disseldorp
2026-03-29 10:30 ` [PATCH v4 1/6] initramfs_test: add fill_cpio() inject_ox parameter David Disseldorp
2026-03-30 9:49 ` Andy Shevchenko
2026-03-29 10:30 ` [PATCH v4 2/6] initramfs_test: test header fields with 0x hex prefix David Disseldorp
2026-03-30 9:52 ` Andy Shevchenko
2026-03-29 10:30 ` [PATCH v4 3/6] initramfs: Sort headers alphabetically David Disseldorp
2026-03-29 10:30 ` [PATCH v4 4/6] initramfs: Refactor to use hex2bin() instead of custom approach David Disseldorp
2026-03-30 9:50 ` Andy Shevchenko [this message]
2026-03-30 9:55 ` Andy Shevchenko
2026-03-30 10:39 ` David Disseldorp
2026-04-01 12:41 ` Petr Mladek
2026-03-29 10:30 ` [PATCH v4 5/6] vsprintf: Revert "add simple_strntoul" David Disseldorp
2026-03-29 10:30 ` [PATCH v4 6/6] kstrtox: Drop extern keyword in the simple_strtox() declarations David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acpHYPiOy-S3PUNT@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ddiss@suse.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox