From: Tyler Hicks <code@tyhicks.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: cleanup truncate handling in ecryptfs v2
Date: Tue, 7 Apr 2026 20:10:29 -0500 [thread overview]
Message-ID: <adWrBVPMUj0otxi_@yaupon> (raw)
In-Reply-To: <adUZs-oTFj5t1Lnh@infradead.org>
On 2026-04-07 07:50:27, Christoph Hellwig wrote:
> On Tue, Apr 07, 2026 at 04:02:36PM +0200, Christoph Hellwig wrote:
> > Hi Tyler,
> >
> > this series cleans up the truncate handling in ecryptfs. I did
> > it as preparation for some changes into size changing truncate
> > VFS interfaces I'm looking into in the moment. The changes have
> > passed the regression test suite in the userspace ecryptfs
> > repository and against the ecryptfs next branch.
>
> So right after I posted this I came up with an idea how to better
> pass arguments to the low-level truncate helper as the size + lower_ia
> kept irking me. The branch here:
>
> https://git.infradead.org/?p=users/hch/misc.git;a=shortlog;h=refs/heads/ecryptfs-truncate
>
> simply only passed the upper ia, which feels a lot cleaner. It passes
> the ecryptfs test suite, but otherwise is hot off the press. If you
> like the new version I'll send it out tomorrow.
>
Yep, that's the right thing to do. Thanks for give it more thought.
I only had time to do a diff between v1 and this branch. The code
changes look good. One tiny typo in a code comment:
s/file systen/file system/
Tyler
prev parent reply other threads:[~2026-04-08 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:02 cleanup truncate handling in ecryptfs v2 Christoph Hellwig
2026-04-07 14:02 ` [PATCH 1/7] ecryptfs: streamline truncate_upper Christoph Hellwig
2026-04-07 14:02 ` [PATCH 2/7] ecryptfs: cleanup ecryptfs_setattr Christoph Hellwig
2026-04-07 14:02 ` [PATCH 3/7] ecryptfs: use ZERO_PAGE instead of allocating zeroed memory in truncate_upper Christoph Hellwig
2026-04-07 14:02 ` [PATCH 4/7] ecryptfs: combine the two ATTR_SIZE blocks in ecryptfs_setattr Christoph Hellwig
2026-04-07 14:02 ` [PATCH 5/7] ecryptfs: sanitize struct iattr handling in truncate_upper Christoph Hellwig
2026-04-07 14:02 ` [PATCH 6/7] ecryptfs: merge ecryptfs_inode_newsize_ok into truncate_upper Christoph Hellwig
2026-04-07 14:02 ` [PATCH 7/7] ecryptfs: call notify_change from truncate_upper Christoph Hellwig
2026-04-07 14:50 ` cleanup truncate handling in ecryptfs v2 Christoph Hellwig
2026-04-08 1:10 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adWrBVPMUj0otxi_@yaupon \
--to=code@tyhicks.com \
--cc=ecryptfs@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox