From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b4-smtp.messagingengine.com (fhigh-b4-smtp.messagingengine.com [202.12.124.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED76C3191A5; Wed, 8 Apr 2026 01:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775610634; cv=none; b=KWWJXY3eQPLgprkakZPr8uvzQO5cmn+bhmrBvi451/JfVGDMWnPmhGnwlcx/tHKyyW6E8V8Sh8EGF64S0u5nU3p8SiK8W8PYVrm6Hg9HZjsWWX7hlzfwWal+VxinWquAgFmcJ2XJR+AYF2tfjXqdyv5zLzUK0Wsg0JUdT+w8HmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775610634; c=relaxed/simple; bh=X/vMTQg9Mg7optEV0JTWExto9WjwKniw/bC23pvy7pg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XEZg3Lw9jWXpIljpN9a5Tw7fom59BoNGsEcaHJ/VTv+ix9bQh/RRMtRHnb76YwB1vinXnaR8E/P84eFvnBmVEgzQR6mHXUeECRLu7f9kltB1Fxq76m8P+659kEvORhj/nSEmg0wgESZZAG2P7fke/3LHzsAh271AH1iSMJ787/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tyhicks.com; spf=pass smtp.mailfrom=tyhicks.com; dkim=pass (2048-bit key) header.d=tyhicks.com header.i=@tyhicks.com header.b=flCTnGJR; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=OJMvNuQx; arc=none smtp.client-ip=202.12.124.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tyhicks.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tyhicks.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tyhicks.com header.i=@tyhicks.com header.b="flCTnGJR"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OJMvNuQx" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 157F77A0260; Tue, 7 Apr 2026 21:10:32 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Tue, 07 Apr 2026 21:10:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tyhicks.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1775610631; x=1775697031; bh=XwjmQG1Z6q 2YIpUddDTDKCwUA8dhQbQ+9xl0vnD4fmA=; b=flCTnGJRBjNc+p3V/SyD2ZUWkN Fxnu6sGSMj3FsCVYCv5sA7kJcUni3xz7p0awTndmwZzy6qCf6Pyom5uSpldNj53l NcJ65vOXz2ew6gfFhm2FryRqGLufCgufHpuWyXgIbcHjXY1b/MHoDjcjb0E1xxr7 iADVDHhg8BnbfRF9LiDcgxzZwKP4UjoIoOgx8n5TUWiK9cgpCDE4xG10j+FVn8/V 0kTWfOT6vgpw8iAY3peuLnUqH7JygpR/LgQ4E5kt5DHhQb3VPQWpllSuGIiSfwd8 VVVbP79F2Ews/H4fbLGtF5xOkvD9OLGsJ6BeCvVDGAs7Usd0NY1jF3+sRObg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1775610631; x=1775697031; bh=XwjmQG1Z6q2YIpUddDTDKCwUA8dhQbQ+9xl 0vnD4fmA=; b=OJMvNuQxQdgGd4hnFFnnSGozLGfWAzfLwTFVVSmE3fELI0AhiWb FiCzbk8v8GNZqtXT7GQo6Wm1Vc/N4a08zY+gI4zUK26mWc5xRZXmsfDG7iV8x1A/ ngBrRUVLY2Vayj9G3ZiHDw0jHAd+FPIV3ziy6MxrDjIkyKwRz4hd4HVewXsXVn/E ADa57Do4t6GH7onNwCqkMs5idVoml7yNVKW7Yd13unw7n6IneVi92kFTPgjJGbWy tobDmqVQMFGmW/sffbTyopk1bxG4pKkaz6KfIAOPR7+b+n/y8rGnuadDEdzQ3YaB EV9p/eN/pWZfC/1x99Psf5eYi1Bos3iFuGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvvddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvhihlvghrucfj ihgtkhhsuceotghouggvsehthihhihgtkhhsrdgtohhmqeenucggtffrrghtthgvrhhnpe etfeffjefgudekleduleeljeevtdfhvdefhfejhfehgffhtddvueellefhgfelheenucff ohhmrghinhepihhnfhhrrgguvggrugdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpegtohguvgesthihhhhitghkshdrtghomhdpnhgs pghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephhgthhesih hnfhhrrgguvggrugdrohhrghdprhgtphhtthhopegvtghrhihpthhfshesvhhgvghrrdhk vghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhfshguvghvvghlsehvghgvrh drkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i78e14604:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Apr 2026 21:10:30 -0400 (EDT) Date: Tue, 7 Apr 2026 20:10:29 -0500 From: Tyler Hicks To: Christoph Hellwig Cc: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: cleanup truncate handling in ecryptfs v2 Message-ID: References: <20260407140329.633186-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2026-04-07 07:50:27, Christoph Hellwig wrote: > On Tue, Apr 07, 2026 at 04:02:36PM +0200, Christoph Hellwig wrote: > > Hi Tyler, > > > > this series cleans up the truncate handling in ecryptfs. I did > > it as preparation for some changes into size changing truncate > > VFS interfaces I'm looking into in the moment. The changes have > > passed the regression test suite in the userspace ecryptfs > > repository and against the ecryptfs next branch. > > So right after I posted this I came up with an idea how to better > pass arguments to the low-level truncate helper as the size + lower_ia > kept irking me. The branch here: > > https://git.infradead.org/?p=users/hch/misc.git;a=shortlog;h=refs/heads/ecryptfs-truncate > > simply only passed the upper ia, which feels a lot cleaner. It passes > the ecryptfs test suite, but otherwise is hot off the press. If you > like the new version I'll send it out tomorrow. > Yep, that's the right thing to do. Thanks for give it more thought. I only had time to do a diff between v1 and this branch. The code changes look good. One tiny typo in a code comment: s/file systen/file system/ Tyler