From: Roland Dreier <rdreier@cisco.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] uverbs: kill last remaining modular get_empty_filp user
Date: Wed, 27 Feb 2008 11:01:45 -0800 [thread overview]
Message-ID: <adaoda2z0iu.fsf@cisco.com> (raw)
In-Reply-To: <20080225191043.GA32342@lst.de> (Christoph Hellwig's message of "Mon, 25 Feb 2008 20:10:43 +0100")
> uvers should be using the proper alloc_file helper instead of an
> open-coded get_empty_filp. In fact this was the last modular user
> so we can kill the export aswell and force people to use the proper
> interface.
As we talked about, I think this patch breaks the module reference
counting for uverbs a little bit.
However, I looked at a few things, and I think with a slight tweak to
the anon-inodes stuff (which I think is a good change anyway), uverbs
can switch to that and drop both get_empty_filp() and all the
infinibandeventfs junk too.
I'll send patches shortly.
- R.
next prev parent reply other threads:[~2008-02-27 19:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 19:10 [PATCH] uverbs: kill last remaining modular get_empty_filp user Christoph Hellwig
2008-02-27 19:01 ` Roland Dreier [this message]
2008-02-27 19:16 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Roland Dreier
2008-02-27 19:18 ` [PATCH 2/2] IB/uverbs: Use anonymous inodes instead of private filesystem Roland Dreier
2008-02-27 19:20 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Avi Kivity
2008-02-27 19:41 ` Davide Libenzi
2008-02-27 20:14 ` Roland Dreier
2008-02-27 20:30 ` Davide Libenzi
2008-02-27 21:05 ` Roland Dreier
2008-02-27 23:42 ` Roland Dreier
2008-02-28 7:52 ` Avi Kivity
2008-02-28 20:04 ` Davide Libenzi
2008-02-28 20:24 ` Roland Dreier
2008-02-28 20:52 ` Davide Libenzi
2008-03-05 9:32 ` Avi Kivity
2008-03-06 15:14 ` Christoph Hellwig
2008-03-09 2:45 ` Roland Dreier
2008-03-17 10:40 ` Christoph Hellwig
2008-03-17 10:48 ` Avi Kivity
2008-03-09 2:46 ` Roland Dreier
2008-03-06 15:14 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaoda2z0iu.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).