From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH] uverbs: kill last remaining modular get_empty_filp user Date: Wed, 27 Feb 2008 11:01:45 -0800 Message-ID: References: <20080225191043.GA32342@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from sj-iport-3.cisco.com ([171.71.176.72]:23499 "EHLO sj-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754539AbYB0TCE (ORCPT ); Wed, 27 Feb 2008 14:02:04 -0500 In-Reply-To: <20080225191043.GA32342@lst.de> (Christoph Hellwig's message of "Mon, 25 Feb 2008 20:10:43 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > uvers should be using the proper alloc_file helper instead of an > open-coded get_empty_filp. In fact this was the last modular user > so we can kill the export aswell and force people to use the proper > interface. As we talked about, I think this patch breaks the module reference counting for uverbs a little bit. However, I looked at a few things, and I think with a slight tweak to the anon-inodes stuff (which I think is a good change anyway), uverbs can switch to that and drop both get_empty_filp() and all the infinibandeventfs junk too. I'll send patches shortly. - R.