From: Roland Dreier <rdreier@cisco.com>
To: "Jörn Engel" <joern@lazybastard.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, akpm@osdl.org,
Albert Cahalan <acahalan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Pekka Enberg <penberg@cs.helsinki.fi>, Greg KH <greg@kroah.com>,
Ingo Oeser <ioe-lkml@rameria.de>
Subject: Re: [PATCH] LogFS take three
Date: Tue, 15 May 2007 19:37:36 -0700 [thread overview]
Message-ID: <adar6pho5n3.fsf@cisco.com> (raw)
In-Reply-To: <20070515151919.GA32510@lazybastard.org> (Jörn Engel's message of "Tue, 15 May 2007 17:19:20 +0200")
There are rather a lot of of FIXME comments, including scary stuff like
> + /*
> + * FIXME: this cannot be right but it does "fix" a bug of i_count
> + * dropping too low. Needs more thought.
> + */
> + atomic_inc(&old_dentry->d_inode->i_count);
and
> +int __logfs_write_inode(struct inode *inode)
> +{
> + /*
> + * FIXME: Those two inodes are 512 bytes in total. Not good to
> + * have on the stack. Possibly the best solution would be to bite
> + * the bullet and do another format change before release and
> + * shrink the inodes.
> + */
> + struct logfs_disk_inode old, new;
are you going to change the format? or fix this some other way?
I think a sweep through the code searching for FIXME and at least
rewriting all such comments to look like stuff that can be deferred
would be warranted ;)
- R.
next prev parent reply other threads:[~2007-05-16 2:38 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 15:19 [PATCH] LogFS take three Jörn Engel
2007-05-15 15:21 ` Review status (Re: [PATCH] LogFS take three) Jörn Engel
2007-05-17 16:03 ` Evgeniy Polyakov
2007-05-17 17:10 ` Jörn Engel
2007-05-20 17:30 ` Evgeniy Polyakov
2007-05-23 12:58 ` Jörn Engel
2007-05-23 15:07 ` Evgeniy Polyakov
2007-05-23 15:14 ` Jörn Engel
2007-05-23 15:53 ` Evgeniy Polyakov
2007-05-15 18:37 ` [PATCH] LogFS take three Sam Ravnborg
2007-05-15 19:10 ` Jörn Engel
2007-05-15 19:07 ` John Stoffel
2007-05-15 19:19 ` Jörn Engel
2007-05-16 4:54 ` David Woodhouse
2007-05-16 11:09 ` Jörn Engel
2007-05-16 11:34 ` Jamie Lokier
2007-05-16 11:38 ` Artem Bityutskiy
2007-05-16 12:25 ` Jamie Lokier
2007-05-16 12:49 ` Jörn Engel
2007-05-16 11:50 ` Jörn Engel
2007-05-16 12:06 ` CaT
2007-05-17 17:07 ` Jan Engelhardt
2007-05-16 12:29 ` Evgeniy Polyakov
2007-05-16 12:55 ` Jörn Engel
2007-05-17 17:08 ` Jan Engelhardt
2007-05-16 13:41 ` John Stoffel
2007-05-16 13:53 ` Jörn Engel
2007-05-16 14:04 ` David Woodhouse
2007-05-16 14:13 ` Artem Bityutskiy
2007-05-16 14:17 ` Kevin Bowling
2007-05-17 9:12 ` Pavel Machek
2007-05-17 9:52 ` David Woodhouse
2007-05-19 15:00 ` Bill Davidsen
2007-05-16 14:29 ` CaT
2007-05-17 17:14 ` Jan Engelhardt
2007-05-19 14:45 ` David Weinehall
2007-05-19 16:17 ` Jamie Lokier
2007-05-19 16:27 ` Evgeniy Polyakov
2007-05-17 16:59 ` Jan Engelhardt
2007-05-17 11:39 ` Arnd Bergmann
2007-05-15 20:37 ` Andrew Morton
2007-05-16 0:06 ` Jörn Engel
2007-05-16 2:11 ` Jörn Engel
2007-05-16 5:22 ` Willy Tarreau
2007-05-16 11:23 ` Jörn Engel
2007-05-17 17:26 ` Jan Engelhardt
2007-05-17 17:45 ` Evgeniy Polyakov
2007-05-18 1:00 ` Kyle Moffett
2007-05-18 6:16 ` Jan Engelhardt
2007-05-16 12:07 ` David Woodhouse
2007-05-16 15:34 ` Andrew Morton
2007-05-16 15:49 ` David Woodhouse
2007-05-16 16:41 ` Jörn Engel
[not found] ` <7fe698080705162312t4e7ed90byd10ef8e664027b17@mail.gmail.com>
2007-05-17 6:25 ` David Woodhouse
2007-05-17 8:20 ` Dongjun Shin
2007-05-17 8:43 ` David Woodhouse
2007-05-17 12:05 ` Jörn Engel
2007-05-17 20:18 ` Pavel Machek
2007-05-18 0:01 ` Dongjun Shin
2007-05-18 6:17 ` Jan Engelhardt
2007-05-18 6:47 ` David Woodhouse
2007-05-19 15:18 ` Bill Davidsen
2007-05-19 6:15 ` Rob Landley
2007-05-19 9:24 ` Jan Engelhardt
2007-05-19 17:26 ` Rob Landley
2007-05-15 23:26 ` Albert Cahalan
2007-05-16 0:09 ` Jörn Engel
2007-05-16 11:18 ` Jamie Lokier
2007-05-16 12:08 ` Pekka Enberg
2007-05-16 12:58 ` Jörn Engel
2007-05-16 2:37 ` Roland Dreier [this message]
2007-05-16 11:35 ` Jörn Engel
2007-05-16 10:21 ` Pekka J Enberg
2007-05-16 12:26 ` Jörn Engel
2007-05-16 12:36 ` Pekka Enberg
2007-05-16 12:38 ` Pekka Enberg
2007-05-16 13:20 ` Jörn Engel
2007-05-17 20:58 ` Pekka Enberg
2007-05-17 21:36 ` Arnd Bergmann
2007-05-17 21:50 ` Jörn Engel
2007-05-16 19:17 ` Pavel Machek
2007-05-16 19:23 ` Jörn Engel
2007-05-17 15:08 ` Arnd Bergmann
2007-05-17 20:21 ` Jörn Engel
2007-05-17 21:00 ` Arnd Bergmann
2007-05-17 21:30 ` Jörn Engel
2007-05-17 22:01 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adar6pho5n3.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=acahalan@gmail.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=ioe-lkml@rameria.de \
--cc=jengelh@linux01.gwdg.de \
--cc=joern@lazybastard.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).